Detaching pre-existing port fails to remove user's dns record

[Hang Yang]

Environment:
Queens: Nova, Neutron, Designate(External DNS)
Network has dns_domain set

Steps to reproduce:
1. Create a port from the network
2. Create an instance with the port attached, dns_name in the port will be updated and a record will be created in user's recordset.
3. Delete the instance.
4. Check the port, the dns_name is reset to empty but the dns record under user's zone is not removed.

This also affects the usage of orchestration components like Senlin/Heat since they usually create a port separately and then create an instance with the port.

This bug was filed in Neutron before and has more debug information: https://bugs.launchpad.net/neutron/+bug/1741079

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/631684

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/633806

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/633807

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/631684
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1b797f6f7e99fdef380340d6fe29e4004be48781
Submitter: Zuul
Branch: master

commit 1b797f6f7e99fdef380340d6fe29e4004be48781
Author: Hang Yang <email address hidden>
Date: Thu Jan 17 16:57:56 2019 -0800

    Fix port dns_name reset

    When external DNS service is enabled, use user's context to request
    dns_name reset instead of using admin context. The dns record need
    be found in user's zone and recordset.

    Change-Id: I35335b501f8961b9ac8e5f92e0686e402b78617b
    Closes-Bug: #1812110

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/633806
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d2662df48526a2a4ddcd4a7bdbb6108102fe8321
Submitter: Zuul
Branch: stable/rocky

commit d2662df48526a2a4ddcd4a7bdbb6108102fe8321
Author: Hang Yang <email address hidden>
Date: Thu Jan 17 16:57:56 2019 -0800

    Fix port dns_name reset

    When external DNS service is enabled, use user's context to request
    dns_name reset instead of using admin context. The dns record need
    be found in user's zone and recordset.

    Change-Id: I35335b501f8961b9ac8e5f92e0686e402b78617b
    Closes-Bug: #1812110
    (cherry picked from commit 1b797f6f7e99fdef380340d6fe29e4004be48781)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/633807
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e5e929f019c05fa57f6b216855b9246b7a5f8d48
Submitter: Zuul
Branch: stable/queens

commit e5e929f019c05fa57f6b216855b9246b7a5f8d48
Author: Hang Yang <email address hidden>
Date: Thu Jan 17 16:57:56 2019 -0800

    Fix port dns_name reset

    When external DNS service is enabled, use user's context to request
    dns_name reset instead of using admin context. The dns record need
    be found in user's zone and recordset.

    Also add show_network to NeutronFixture as needed in functional
    test given I621f5111d1cccf3dc2c2ea6767ce879bc286e42b has not been
    backported yet in stable/queens.

    Change-Id: I35335b501f8961b9ac8e5f92e0686e402b78617b
    Closes-Bug: #1812110
    (cherry picked from commit 1b797f6f7e99fdef380340d6fe29e4004be48781)
    (cherry picked from commit d2662df48526a2a4ddcd4a7bdbb6108102fe8321)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.10 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 18.2.0 release.