nova-manage db purge -h has weird help for --before option

Bug #1802167 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Takashi Natsume

Bug Description

This is probably due to not having a metavar defined for the --before option, but the help output is weird:

stack@stein:~/nova$ nova-manage db purge -h
/usr/local/lib/python2.7/dist-packages/psycopg2/__init__.py:144: UserWarning: The psycopg2 wheel package will be renamed from release 2.8; in order to keep installing from binary please use "pip install psycopg2-binary" instead. For details see: <http://initd.org/psycopg/docs/install.html#binary-install-from-pypi>.
  """)
usage: nova-manage db purge [-h] [--before ACTION_KWARG_BEFORE] [--all]
                            [--verbose] [--all-cells]

optional arguments:
  -h, --help show this help message and exit
  --before ACTION_KWARG_BEFORE
                        If specified, purge rows from shadow tables that are
                        older than this. Fuzzy time specs are allowed
  --all Purge all rows in the shadow tables
  --verbose Print information about purged records
  --all-cells Run against all cell databases
stack@stein:~/nova$

Notably the "ACTION_KWARG_BEFORE" thing.

Matt Riedemann (mriedem)
description: updated
Changed in nova:
assignee: nobody → Takashi NATSUME (natsume-takashi)
Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/616723

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/616723
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=dda614c7722973a200278c37ace569cd056d5f50
Submitter: Zuul
Branch: master

commit dda614c7722973a200278c37ace569cd056d5f50
Author: Takashi NATSUME <email address hidden>
Date: Fri Nov 9 10:43:15 2018 +0900

    Fix a help string in nova-manage

    Fix a help string of the '--before' argument
    in the 'nova-manage db purge' command.

    Change-Id: I21845c52e09bb794e52bd7375fb70a498aab92ed
    Closes-Bug: #1802167

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.0.0rc1

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.