OpenStack Compute (nova)

Improper error message handling

Bug #1801713 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Lucian Petrut
compute-hyperv
Fix Released
Undecided
Unassigned

Bug Description

Exception messages are expected to be strings, but it's not always the case. Some exceptions are wrapped and passed as new exception messages, which affects some exception handlers.

Trace: http://paste.openstack.org/show/733939/

Finding all the occurrences may be difficult. For now, it may be easier to just convert the exception messages to strings in the NovaException class.

See original description
Lucian Petrut (petrutlucian94)
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/615550

Changed in nova:
assignee: nobody → Lucian Petrut (petrutlucian94)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to compute-hyperv (master)

Reviewed: https://review.openstack.org/615560
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=2757ac74b7d2c85a257ed5accced1e2c7e622827
Submitter: Zuul
Branch: master

commit 2757ac74b7d2c85a257ed5accced1e2c7e622827
Author: Lucian Petrut <email address hidden>
Date: Mon Nov 5 15:37:54 2018 +0200

    Trivial: use string for exception message

    Exception messages are expected to be strings. Some Nova exception
    handlers will fail when encountering wrapped exceptions.

    This change fixes the only occurrence of this issue.

    Change-Id: If35f7b99f9c0b9f0edd614dc96842549e6ac19c1
    Closes-Bug: #1801713

Changed in compute-hyperv:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/615550
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fcb26b5401ccd01e91577af4111d79b605788889
Submitter: Zuul
Branch: master

commit fcb26b5401ccd01e91577af4111d79b605788889
Author: Lucian Petrut <email address hidden>
Date: Mon Nov 5 14:17:40 2018 +0200

    Convert exception messages to strings

    Exception messages are expected to be strings, but it's not always
    the case. Some exceptions are wrapped and passed as new exception
    messages, which affects some exception handlers.

    Finding all the occurrences may be difficult. For now, it's easier
    to just convert the exception messages to strings in the NovaException
    class.

    Closes-Bug: #1801713

    Change-Id: Ic470791aa2b08ca9911bf70cb3cc68652d3647f2

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.0.0rc1

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/compute-hyperv 9.0.0.0rc1

This issue was fixed in the openstack/compute-hyperv 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.