2.66 server-get-resp.json API sample is wrong - and likely not tested

[Matt Riedemann]

The API sample for the GET /servers/{server_id} response is clearly not correct:

https://github.com/openstack/nova/blob/f13debf2f0e5377b9d0b0bbd9422c6a79d2cc611/doc/api_samples/servers/v2.66/server-get-resp.json

Since a GET on a single server does not return a list. So this likely isn't tested. If we don't actually need the sample, since 2.66 is about listing servers and filtering with changes-before, we can remove the sample.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/614671

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614671
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=21fb8b65c7161b1f4c52e11f8a71fb5a13940af6
Submitter: Zuul
Branch: master

commit 21fb8b65c7161b1f4c52e11f8a71fb5a13940af6
Author: zhangbailin <email address hidden>
Date: Wed Oct 31 21:59:28 2018 -0400

    Remove useless test samples for v2.66

    These samples were unused and incorrect. We don't actually need the
    sample, since v2.66 is about listing servers and filtering with
    'changes-before', so responses to show a server are unnecessary. Simply
    remove the sample.

    Closes-Bug: #1800936
    Change-Id: I12cf3ffd75098677cf5de1a5f40d783bb661fd74

[Stephen Finucane (stephenfinucane)]

Patch is merged but things didn't link back. Weird. Done now.

[Stephen Finucane (stephenfinucane)]

Nope, I just hadn't refreshed my window...

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.