When ``changes-before`` < ``changes-since``, getting instance migrations records is null

Bug #1796008 reported by Brin Zhang
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Brin Zhang

Bug Description

This need to process the period time.
If ``changes-since`` and ``changes-before`` are all requested in rest URL, judge them:

The value of ``changes-since`` must be less than or equal to ``changes-before``, Otherwise return 400 error.

Tags: api
Brin Zhang (zhangbailin)
Changed in nova:
assignee: nobody → Brin Zhang (zhangbailin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/607798

Changed in nova:
status: New → In Progress
tags: added: api
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/613070

Changed in nova:
assignee: Brin Zhang (zhangbailin) → Matt Riedemann (mriedem)
Matt Riedemann (mriedem)
Changed in nova:
assignee: Matt Riedemann (mriedem) → Brin Zhang (zhangbailin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/613070

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/607798
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a3a0068929136d3bf6e25338889fd3090938eac6
Submitter: Zuul
Branch: master

commit a3a0068929136d3bf6e25338889fd3090938eac6
Author: zhangbailin <email address hidden>
Date: Wed Oct 3 23:03:58 2018 -0400

    Add restrictions on updated_at when getting migrations

    If ``changes-before`` is less than ``changes-since`` in requested,
    there will get empty data when querying in db, so add the limit of
    these parameters. If ``changes-before`` < ``changes-since``, will
    be returned 400.

    Closes-Bug: #1796008
    Change-Id: I2a39ac5a9fe969d383099b4e766c46ad05d9f67c

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.0.0rc1

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.