Can not detach port when vm is soft-deleted

[huanhongda]

Description
===========
When vm is soft-deleted, we can not detach port from it. But when vm is shutoff, we can detach port.
VM in SOFT-DELETED and SHUTOFF status are the same status at the hypervisor level. The guest is shutdown. Why can't they do the same operation?

Steps to reproduce
==================
1) set reclaim_instance_interval > 0 to enable soft-delete
2) create an instance vm01
3) create a port port01 and then attach it to vm01
4) delete vm01
5) detach port01 from vm01

Expected result
===============
port01 can be detached successfully.

Actual result
=============
The detach operation failed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/605602

[OpenStack Infra (hudson-openstack)]

Change abandoned by Balazs Gibizer (<email address hidden>) on branch: master
Review: https://review.opendev.org/605602
Reason: This is an old patch with negative code review. I'm abandoning it.

[Balazs Gibizer (balazs-gibizer)]

I don't think this is a bug per se. Soft delete means you might or might not want to restore the instance that is being deleted. If the instance is end up being really deleted then the port will be freed anyhow. But if the instance will be restored then the port is still need to be present so your instance is restored to the state from where it was soft deleted.

Marking this bug Opinion. If you disagree please set it back to New.