The eventlet.monkey_patch is not valid under uwsgi mode

Bug #1787331 reported by Yikun Jiang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Yikun Jiang

Bug Description

There was a eventlet.monkey_patch [1] when we launch a nova process(like nova-api, nova-compute), but it's invalid under the uwsgi mode.

So, we need do same monkey_patch when we setup uwsgi appilication.

[1] https://github.com/openstack/nova/blob/233ea58/nova/cmd/__init__.py#L26

Tags: api
Changed in nova:
assignee: nobody → Yikun Jiang (yikunkero)
status: New → In Progress
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/592285
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=23ba1c690652832c655d57476630f02c268c87ae
Submitter: Zuul
Branch: master

commit 23ba1c690652832c655d57476630f02c268c87ae
Author: Yikun Jiang <email address hidden>
Date: Thu Aug 16 14:29:26 2018 +0800

    Make monkey patch work in uWSGI mode

    There was a eventlet.monkey_patch [1] when we launch a nova
    process(like nova-api, nova-compute), but it's invalid under
    the uwsgi mode.

    But there are concurrency requirements in the api service, such
    as, when listing instances cross multiple cells we're using
    greenthreads and oslo.db does a time.sleep to allow switching
    greenthreads [2].

    So, in this patch we add the monkey_patch in the uwsgi
    application setup and refactor the monkey patching to use common
    code.

    [1] https://github.com/openstack/nova/blob/233ea58/nova/cmd/__init__.py#L26
    [2] https://github.com/openstack/oslo.db/blob/9c66959/oslo_db/sqlalchemy/engines.py#L51

    Closes-bug: #1787331

    Change-Id: Ie7bf5d012e2ccbcd63c262ddaf739782afcdaf56

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.0.0rc1

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.