tempest-full-py3 runs on test-only changes

Bug #1785425 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Ghanshyam Mann
Queens
Fix Committed
Medium
Matt Riedemann

Bug Description

I'm not sure if this is due to the tempest-full rename to tempest-full-py3 but it seems like this didn't used to be an issue. But we now run tempest-full-py3 even on test-only changes, like this change:

https://review.openstack.org/#/c/588935/

My guess is we had this handled for tempest-full because of the irrelevant-files list in project-config:

https://github.com/openstack-infra/project-config/blob/3d9c5399fdb9b16d3d0391f1d4f32e904db16388/zuul.d/projects.yaml#L9369

Tags: testing zuul
Matt Riedemann (mriedem)
Changed in nova:
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/589039

Changed in nova:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
status: Confirmed → In Progress
Changed in nova:
assignee: Ghanshyam Mann (ghanshyammann) → Matt Riedemann (mriedem)
Matt Riedemann (mriedem)
Changed in nova:
assignee: Matt Riedemann (mriedem) → Ghanshyam Mann (ghanshyammann)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/589039
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=65cdcf4aaa9aec2fbeb29c9734b07efff32a2c49
Submitter: Zuul
Branch: master

commit 65cdcf4aaa9aec2fbeb29c9734b07efff32a2c49
Author: ghanshyam <email address hidden>
Date: Mon Aug 6 07:23:16 2018 +0000

    Define irrelevant-files for tempest-full-py3 job

    tempest-full-py3 job runs on nova check and gate pipeline
    as part of 'integrated-gate-py35' template.

    Unlike tempest-full or other job, nova job definition list on
    project-config side[1] does not define the irrelevant-files for
    tempest-full-py job which leads to run this job on doc/test file
    only change also.

    This commit defines the irrelevant-files for tempest-full-py3 on
    nova's zuul.yaml.

    Closes-Bug: #1785425

    [1] https://github.com/openstack-infra/project-config/blob/57907fbf04c3f9a69d390efee800d42697faae16/zuul.d/projects.yaml#L9283

    Change-Id: I887177c078a53c53e84289a6b134d7ea357dfbef

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0rc1

This issue was fixed in the openstack/nova 18.0.0.0rc1 release candidate.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Also seeing this in stable/queens: https://review.openstack.org/#/c/649362/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/650460

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.opendev.org/650460
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=dba9b722afa7904e704db54af076f1de123f78e9
Submitter: Zuul
Branch: stable/queens

commit dba9b722afa7904e704db54af076f1de123f78e9
Author: ghanshyam <email address hidden>
Date: Mon Aug 6 07:23:16 2018 +0000

    Define irrelevant-files for tempest-full-py3 job

    tempest-full-py3 job runs on nova check and gate pipeline
    as part of 'integrated-gate-py35' template.

    Unlike tempest-full or other job, nova job definition list on
    project-config side[1] does not define the irrelevant-files for
    tempest-full-py job which leads to run this job on doc/test file
    only change also.

    This commit defines the irrelevant-files for tempest-full-py3 on
    nova's zuul.yaml.

    Closes-Bug: #1785425

    [1] https://github.com/openstack-infra/project-config/blob/57907fbf04c3f9a69d390efee800d42697faae16/zuul.d/projects.yaml#L9283

    Conflicts:
          .zuul.yaml

    NOTE(mriedem): The conflict is due to not having change
    Ic28558ee6481d49a9b4e5dc2c4182504e330448f in Queens.
    Also, since Ife046b91c96dd300e8c46125b75623d8e12b8da3 is
    not in Queens the irrelevant-files list is copied from
    the tempest-full job.

    Change-Id: I887177c078a53c53e84289a6b134d7ea357dfbef
    (cherry picked from commit 65cdcf4aaa9aec2fbeb29c9734b07efff32a2c49)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.11

This issue was fixed in the openstack/nova 17.0.11 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.