os-server-groups API samples should indicate they are using microversion 2.64

Bug #1785415 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Yikun Jiang

Bug Description

The samples in https://developer.openstack.org/api-ref/compute/#server-groups-os-server-groups are using microversion 2.64 but don't explicitly say that. The samples were changed in Rocky with change:

https://github.com/openstack/nova/commit/5cdb1ce26b0ec53c231723bcc6ce880aa8f43f0f

Normally when the API samples are using a microversion beyond 2.1, they put that into the description of the request/response samples, like this:

https://github.com/openstack/nova/blob/b046a998443d4586d4ca7a2863b785b909a4d076/api-ref/source/os-hypervisors.inc

Example List Hypervisors (v2.33): JSON response

So we'll want something like "(v2.64)" in the os-server-groups samples.

Matt Riedemann (mriedem)
tags: added: low-hanging-fruit
Changed in nova:
assignee: nobody → Yikun Jiang (yikunkero)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/589006

Changed in nova:
status: Triaged → In Progress
Changed in nova:
assignee: Yikun Jiang (yikunkero) → Matt Riedemann (mriedem)
Matt Riedemann (mriedem)
Changed in nova:
assignee: Matt Riedemann (mriedem) → Yikun Jiang (yikunkero)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/589006
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=00b585a1b94099e58177a04b204ca94fa0bc5908
Submitter: Zuul
Branch: master

commit 00b585a1b94099e58177a04b204ca94fa0bc5908
Author: Yikun Jiang <email address hidden>
Date: Mon Aug 6 10:33:27 2018 +0800

    Add microversion info in the os-server-groups API samples

    The os-server-groups samples are using 2.64 but don't explicitly say
    that, so we need something like "(v2.64)" in the os-server-groups.inc.

    In this patch, we add microversion info in the os-server-groups API
    samples.

    Change-Id: Ia7e25ceba532e6cfd0ed18cf3cc8113512d50323
    Closes-bug: #1785415

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0rc1

This issue was fixed in the openstack/nova 18.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.