docs for RPC is out of date

Bug #1785086 reported by Chris Friesen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
In Progress
Medium
Stephen Finucane

Bug Description

The information in doc/source/reference/rpc.rst is stale and should probably be updated or removed so that it doesn't confuse people.

Tags: doc
Revision history for this message
Matt Riedemann (mriedem) wrote :

Would be nice to be more specific, rather than a general scrubbing (which is probably harder for someone that's not intimately familiar with rpc in nova, like dansmith). I know you specifically pointed out (in IRC) that there were some issues with the durable queues stuff.

Maybe a good first pass would just be scrubbing the config options mentioned in there?

Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Chris Friesen (cbf123) wrote :

I think there are a bunch of things that are stale.

For example..."Nova uses Kombu to connect to the RabbitMQ environment." As far as I know nova no longer directly uses Kombu, instead it uses oslo.messaging (which may in turn use kombu but nova doesn't know about it). This means that many of the parameters documented for kombu (like "routing_key" and "durable" and "exchange_type") are no longer applicable.

Similarly, the "delivery_mode" parameter doesn't seem to be relevent to nova anymore.

tags: added: doc
removed: docs
Sapna Jadhav (sapana45)
Changed in nova:
assignee: nobody → Sapna Jadhav (sapana45)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/664153

Changed in nova:
status: Confirmed → In Progress
Changed in nova:
assignee: Sapna Jadhav (sapana45) → Stephen Finucane (stephenfinucane)
Revision history for this message
Gabriele Santomaggio (gsantomaggio) wrote :

speaking about the documentation there are few errors, or let's say imprecisions
https://docs.openstack.org/nova/stein/reference/rpc.html

1.
```
Nova uses Kombu to connect to the RabbitMQ environment. Kombu is a Python library that in turn uses AMQPLib,
```
AMQPLib is a nodejs lib, the correct one is `py-amqp`

2.
```
a library that implements the standard AMQP 0.8
```
AMQP 0.9.1 not AMQP 0.8

3.
Nova uses Kombu to connect to the RabbitMQ ...
```
should be:
```
Nova uses olso.messaging
```

At this point I'd link to olso messaging documentation,else is redundant information that can cause entropy.

It is not correct ( in my opinion ) to report all this info. That is generic info and not specific to nova.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Stephen Finucane (<email address hidden>) on branch: master
Review: https://review.opendev.org/664153

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.