live migration to non-existing host gets instance stuck in "migrating" status

[Mike Chen]

Description
===========
When doing live-migration, if a host that does not exist or cannot be found is specified as destination, live-migration will fail and instance will get stuck in status "migrating".

Steps to reproduce
==================
nova live-migration vm non_existing_host

Expected result
===============
live-migration fails and instance rolls back to initial state

Actual result
=============
live-migration fails but instance's status remains "migrating"

Environment
===========
nova --version
10.1.0 (queens release)

Logs & Configs
==============
not related

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/588512

[Matt Riedemann (mriedem)]

This is really a duplicate bug and the original fix is here:

https://review.openstack.org/#/c/401009/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Chen (<email address hidden>) on branch: master
Review: https://review.openstack.org/588512
Reason: duplicate of https://review.openstack.org/#/c/401009/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/401009
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c7aed3d139909913387e4ac2e771f19c9502c5b1
Submitter: Zuul
Branch: master

commit c7aed3d139909913387e4ac2e771f19c9502c5b1
Author: Sivasathurappan Radhakrishnan <email address hidden>
Date: Wed Nov 23 00:17:47 2016 +0000

    Fix host validity check for live-migration

    When live migrating instance to invalid host, live migration fails
    with host not found and sets instance task state to migrating.

    This change handles host validity in API layer before changing instance
    task_state to 'MIGRATING' and raise proper exception on invalid host.

    Change-Id: I7c5e80298b9adf1bd53cc6c464a3744b5397b7e8
    Related-Bug: #1643623
    Closes-Bug: #1785031

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/590262

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/590263

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/590262
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0a60496ddbcd3480a342492125c0adcf461324bd
Submitter: Zuul
Branch: stable/queens

commit 0a60496ddbcd3480a342492125c0adcf461324bd
Author: Sivasathurappan Radhakrishnan <email address hidden>
Date: Wed Nov 23 00:17:47 2016 +0000

    Fix host validity check for live-migration

    When live migrating instance to invalid host, live migration fails
    with host not found and sets instance task state to migrating.

    This change handles host validity in API layer before changing instance
    task_state to 'MIGRATING' and raise proper exception on invalid host.

    Change-Id: I7c5e80298b9adf1bd53cc6c464a3744b5397b7e8
    Related-Bug: #1643623
    Closes-Bug: #1785031
    (cherry picked from commit c7aed3d139909913387e4ac2e771f19c9502c5b1)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/590611

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 18.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.6 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/590263
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=064daf9aeb39a7f977de4989ad096821e7830ff6
Submitter: Zuul
Branch: stable/pike

commit 064daf9aeb39a7f977de4989ad096821e7830ff6
Author: Sivasathurappan Radhakrishnan <email address hidden>
Date: Wed Nov 23 00:17:47 2016 +0000

    Fix host validity check for live-migration

    When live migrating instance to invalid host, live migration fails
    with host not found and sets instance task state to migrating.

    This change handles host validity in API layer before changing instance
    task_state to 'MIGRATING' and raise proper exception on invalid host.

    Change-Id: I7c5e80298b9adf1bd53cc6c464a3744b5397b7e8
    Related-Bug: #1643623
    Closes-Bug: #1785031
    (cherry picked from commit c7aed3d139909913387e4ac2e771f19c9502c5b1)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/590611
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fbc91183ffa32e881ca5cf15758f5f602401acc0
Submitter: Zuul
Branch: stable/ocata

commit fbc91183ffa32e881ca5cf15758f5f602401acc0
Author: Sivasathurappan Radhakrishnan <email address hidden>
Date: Wed Nov 23 00:17:47 2016 +0000

    Fix host validity check for live-migration

    When live migrating instance to invalid host, live migration fails
    with host not found and sets instance task state to migrating.

    This change handles host validity in API layer before changing instance
    task_state to 'MIGRATING' and raise proper exception on invalid host.

    Change-Id: I7c5e80298b9adf1bd53cc6c464a3744b5397b7e8
    Related-Bug: #1643623
    Closes-Bug: #1785031
    (cherry picked from commit c7aed3d139909913387e4ac2e771f19c9502c5b1)
    (cherry picked from commit 064daf9aeb39a7f977de4989ad096821e7830ff6)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.1.6 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.1.5 release.