OpenStack Compute (nova)

Redundant join in _anchors_for_sharing_providers

Bug #1784604 reported by Yikun Jiang on 2018-07-31

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Yikun Jiang

Bug Description

There is a redundant join when we want to get id from _anchors_for_sharing_providers. The last outerjoin is used to get the rp.UUID according rp.id [1], if we set get_id=True, we no longer need this outer join.

[1] https://github.com/openstack/nova/blob/3ce7fa5/nova/api/openstack/placement/objects/resource_provider.py#L476-L479

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-07-31: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/587377

Changed in nova:
assignee:	nobody → Yikun Jiang (yikunkero)
status:	New → In Progress

Chris Dent (cdent) on 2018-07-31

tags:

added: placement

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-07-31: Fix merged to nova (master)

Reviewed: https://review.openstack.org/587377
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1c66a4b029cc9f939f596cd08ae4c20894d3550e
Submitter: Zuul
Branch: master

commit 1c66a4b029cc9f939f596cd08ae4c20894d3550e
Author: Yikun Jiang <email address hidden>
Date: Tue Jul 31 18:27:39 2018 +0800

Remove redundant join in _anchors_for_sharing_providers

    There is a redundant join when we want to get id from
    _anchors_for_sharing_providers. The last outerjoin is used to get the
    rp.UUID according rp.id, if we set get_id=True, we no longer need this
    outer join.

So, we remove the redundant join in this patch.

Change-Id: Ib5fc6e4efae29dd88ce92df834700d2121ed8076
Closes-bug: #1784604