Possible race updating consumer's proj/user

[Eric Fried]

This is to track [1] so we don't lose sight of it. We first need to figure out a way to test this scenario to see if this is an issue at all.

[1] https://review.openstack.org/#/c/581139/3/nova/api/openstack/placement/util.py@650

[Matt Riedemann (mriedem)]

From my comment in that review:

"I'm not super concerned about rolling this back if it happens and there is a failure creating one of the other allocations from the payload because (a) I'm not sure when this would really happen besides POSTing allocations during a nova server move operation and we're *correcting* latent sentinel project/user info and (b) if that is the case, then we've inadvertently healed the consumer record anyway."

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/581139
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4f9a7da5819b4cc2c181506c682a092caff40fb3
Submitter: Zuul
Branch: master

commit 4f9a7da5819b4cc2c181506c682a092caff40fb3
Author: Jay Pipes <email address hidden>
Date: Mon Jul 9 17:26:52 2018 -0400

    update project/user for consumer in allocation

    Adds code to the util.ensure_consumer() method that updates the
    consumer's project and user foreign key identifiers when a user supplies
    a different external project or user identifier in the paylod of PUT
    /allocations/{consumer_uuid} or POST /allocations.

    Change-Id: I9368ad2280551ffa9a011d3a30c4b45861305455
    Closes-bug: #1779717
    Related-Bug: #1781008