Confusing usage information in max_instances_per_host config option

Bug #1774676 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
tianhui

Bug Description

https://docs.openstack.org/nova/latest/configuration/config.html#filter_scheduler.max_instances_per_host

Refers to the "num_instances_filter" but that's the name of the python module, not the actual filter, and there are two of them:

NumInstancesFilter
AggregateNumInstancesFilter

So the config option help text should be updated to use the actual filter names that would go in the 'enabled_filters' option, not the python module in which those filters live.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/571998

Changed in nova:
assignee: nobody → tianhui (tianhui)
status: Triaged → In Progress
Changed in nova:
assignee: tianhui (tianhui) → Jay Pipes (jaypipes)
Jay Pipes (jaypipes)
Changed in nova:
assignee: Jay Pipes (jaypipes) → tianhui (tianhui)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/571998
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1b4d87b33f93ab41721a77b1adc5c837833570be
Submitter: Zuul
Branch: master

commit 1b4d87b33f93ab41721a77b1adc5c837833570be
Author: tianhui <email address hidden>
Date: Mon Jun 4 10:14:49 2018 +0800

    Fix bug to filter_scheduler

    In https://docs.openstack.org/nova/latest/configuration/config.html#filter_scheduler.max_instances_per_host
    refers to the "num_instances_filter" but that's the name
    of the python module, not the actual filter.
    So the config option help text should be updated to use
    the actual filter names that would go in the 'enabled_filters'
    option, not the python module in which those filters live.

    Change-Id: Icf7e64ed45fa5013714d85ea22794f106d4e387c
    Closes-bug: #1774676

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0b3

This issue was fixed in the openstack/nova 18.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.