OpenStack Compute (nova)

hyper-v: Unused images are always deleted

Bug #1773342 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Hesam Chobanlou
compute-hyperv
Fix Released
Undecided
Unassigned

Bug Description

The Hyper-V driver will always delete unused images, ignoring the "remove_unused_base_images" config option.

One workaround would be to set "remove_unused_original_minimum_age_seconds" to a really large value (e.g. 2^30). Setting it to -1 won't help either.

Lucian Petrut (petrutlucian94)
tags: added: hyper-v
summary: - Unused images are always deleted
+ hyper-v: Unused images are always deleted
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to compute-hyperv (master)

Reviewed: https://review.openstack.org/570571
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=7caef58be03cee448d5845628b59ddd669511b87
Submitter: Zuul
Branch: master

commit 7caef58be03cee448d5845628b59ddd669511b87
Author: Lucian Petrut <email address hidden>
Date: Fri May 25 14:26:19 2018 +0300

    Avoid cleaning up cached images when configured not to

    This change ensure that we're honoring the "remove_unused_base_images"
    config option, allowing deployers to disable the auto-removal of
    old images.

    Change-Id: I49a0a83ab34ca0b9da5d589aaa9006d169275b15
    Closes-Bug: #1773342

Changed in compute-hyperv:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to compute-hyperv (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/588238

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to compute-hyperv (stable/queens)

Reviewed: https://review.openstack.org/588238
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=35fc2fa6da8e994d706027e97226e6b5caf5d876
Submitter: Zuul
Branch: stable/queens

commit 35fc2fa6da8e994d706027e97226e6b5caf5d876
Author: Lucian Petrut <email address hidden>
Date: Fri May 25 14:26:19 2018 +0300

    Avoid cleaning up cached images when configured not to

    This change ensure that we're honoring the "remove_unused_base_images"
    config option, allowing deployers to disable the auto-removal of
    old images.

    Change-Id: I49a0a83ab34ca0b9da5d589aaa9006d169275b15
    Closes-Bug: #1773342
    (cherry picked from commit 7caef58be03cee448d5845628b59ddd669511b87)

tags: added: in-stable-queens
Revision history for this message
melanie witt (melwitt) wrote :

On this bug, I see that a fix was merged to the openstack/compute-hyperv repo. Looks like all we need to do is make the same exact change to the in-tree hyperv code.

Changed in nova:
importance: Undecided → Medium
status: New → Confirmed
status: Confirmed → Triaged
tags: added: low-hanging-fruit
Hesam Chobanlou (hesamchobanlou)
Changed in nova:
assignee: nobody → Hesam Chobanlou (hesamchobanlou)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/628793

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/628793
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=716d17e05491b5d319025cfce221eca5f78e02c0
Submitter: Zuul
Branch: master

commit 716d17e05491b5d319025cfce221eca5f78e02c0
Author: Hesam Chobanlou <email address hidden>
Date: Sun Jan 6 19:55:24 2019 -0500

    unused images are always deleted (add to in-tree hper-v code)

    This is to apply changes applied to openstack/computer-hyperv
    to the in-tree hyper-v code.

    Change-Id: Ib89c2e407bea5168f2eebb12cfb2d50e4566ff7a
    Closes-Bug: #1773342

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.0.0rc1

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/compute-hyperv 9.0.0.0rc1

This issue was fixed in the openstack/compute-hyperv 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.