Comment 2 for bug 1773225

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/575127
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=450444a7829506f5539bf25ecf6cee1c5d82c48d
Submitter: Zuul
Branch: master

commit 450444a7829506f5539bf25ecf6cee1c5d82c48d
Author: Chris Dent <email address hidden>
Date: Wed Jun 13 15:16:35 2018 +0100

    [placement] replace deprecated accept.best_match

    Webob has deprecated the best_match[1] method on accept headers and now
    spews warnings when it sees it.

    This change fixes it by using the equivalent (but more correct with
    regard to the relevant RFCs[2]) acceptable_offers[3] method.

    Existing unit tests in placement/test_util.py cover this change.

    [1] https://docs.pylonsproject.org/projects/webob/en/stable/api/webob.html#webob.acceptparse.AcceptValidHeader.best_match
    [2] https://tools.ietf.org/html/rfc7231#section-5.3.2
    [3] https://docs.pylonsproject.org/projects/webob/en/stable/api/webob.html#webob.acceptparse.AcceptValidHeader.acceptable_offers

    Change-Id: Ie4d81fa178b3ed6b2a7b450b4978009486f07810
    Closes-Bug: #1773225