Comment 25 for bug 1771506

Reviewed: https://review.opendev.org/656304
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=64793cf6f77c5ba7c9ea51662d936c7545ffce8c
Submitter: Zuul
Branch: stable/stein

commit 64793cf6f77c5ba7c9ea51662d936c7545ffce8c
Author: Corey Bryant <email address hidden>
Date: Thu Feb 7 10:12:54 2019 -0500

    xenapi/agent: Change openssl error handling

    Prior to this patch, if the openssl command returned a zero exit code
    and wrote details to stderr, nova would raise a RuntimeError exception.
    This patch changes the behavior to only raise a RuntimeError exception
    when openssl returns a non-zero exit code. Regardless of the exit code
    a warning will always be logged with stderr details if stderr is not
    None. Note that processutils.execute will now raise a
    processutils.ProcessExecutionError exception for any non-zero exit code
    since we are passing check_exit_code=True, which we convert to a
    Runtime error.

    Thanks to Dimitri John Ledkov <email address hidden> and Eric Fried
    <email address hidden> for helping with this patch.

    Change-Id: I212ac2b5ccd93e00adb7b9fe102fcb70857c6073
    Partial-Bug: #1771506
    (cherry picked from commit 1da71fa4ab1d7d0f580cd5cbc97f2dfd2e1c378a)