Local disk without enough capacity appears in allocation candidates

[Tetsuro Nakamura]

How to reproduce
-------------------------

In placement,
1. Setup a compute node resource provider with inventories of
    - 24 VCPU
    - 2048 MEMORY_MB
    - 1600 DISK_GB
2. Setup a shared storage resource provider with "MISC_SHARES_VIA_AGGREGATE" tag with
    - 2000 DISK_GB inventory
3. Set them both in a same aggregate
4. Get allocation candidates requesting
    - 1 VCPU
    - 64 MEMORY_MB
    - 1800 DISK_GB inventory.

Expected
-------------

Get one allocation request where DISK inventory is provided by the shared storage

Actual
----------

Get two allocation request, in one of which DISK inventory is provided by the compute node

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/566842

[Eric Fried (efried)]

This was fixed incidentally via 9af073384cca305565e741c1dfbb359c1e562a4e

See related fix.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566842
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=12948cfe73fce42dde8a2dfdd049dc632ab273a7
Submitter: Zuul
Branch: master

commit 12948cfe73fce42dde8a2dfdd049dc632ab273a7
Author: Tetsuro Nakamura <email address hidden>
Date: Tue May 8 15:57:11 2018 +0900

    Add tests for alloc cands with poor local disk

    This patch deletes a duplicative test and enhance it to validate a
    case where a compute node's local disk is not enough while there
    is a shared storage with enough disk.

    This case has been already fixed thanks to new _exceeds_capacity
    function from commit 9af073384cca305565e741c1dfbb359c1e562a4e.

    Change-Id: Ia544dc529c844f7bee5b04f90456fd66a20ecdd0
    Related-Bug: #1769854