The user_id field is missing from RequestSpec

Bug #1768107 reported by Mathieu Gagné
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Mathieu Gagné

Bug Description

The user_id field used to be available from filter_properties in Nova scheduler filter:

    filter_properties['request_spec']['instance_properties']['user_id']

This change introduced a regression where user_id is no longer available when using the new RequestSpec object that Nova scheduler filter now uses:
https://review.openstack.org/#/c/197912/

Tags: scheduler
Mathieu Gagné (mgagne)
Changed in nova:
assignee: nobody → Mathieu Gagné (mgagne)
status: New → In Progress
Revision history for this message
Matt Riedemann (mriedem) wrote :

To be clear, there are no in-tree filters that rely on RequestSpec.user_id, but people have out of tree filters that could have been using filter_properties['instance_properties']['user_id'] and the change in mitaka regressed them. It also seems OK to have RequestSpec.user_id since we have RequestSpec.project_id, and I could see it being useful to know which user created an instance when it's being moved if another user in the same project is moving the instance.

Changed in nova:
importance: Undecided → Medium
tags: added: scheduler
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/565340

Changed in nova:
assignee: Mathieu Gagné (mgagne) → Matt Riedemann (mriedem)
Matt Riedemann (mriedem)
Changed in nova:
assignee: Matt Riedemann (mriedem) → Mathieu Gagné (mgagne)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/565340
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6e49019fae80586c4bbb8a7281600cf6140c176a
Submitter: Zuul
Branch: master

commit 6e49019fae80586c4bbb8a7281600cf6140c176a
Author: Mathieu Gagné <email address hidden>
Date: Tue Aug 15 16:52:25 2017 -0400

    Add user_id to RequestSpec

    The user_id field was not implemented in RequestSpec like project_id was.
    Some people have out of tree filters which use the user_id field.

    This change makes the user_id field available.

    Closes-bug: #1768107
    Change-Id: I3e174ae76931f8279540e92328c7c36a7bcaabc0

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0b2

This issue was fixed in the openstack/nova 18.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.