OpenStack Compute (nova)

The performance of list instances with IP filter can be improved

Bug #1764685 reported by Zhenyu Zheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Zhenyu Zheng
Queens
Fix Committed
Low
Matt Riedemann

Bug Description

When list instances with IP filter, there is no need
to try to get instances from BuildRequest, as building
instances will not have IP address. Skip this db call
can slightly improve performance.

OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: nobody → Zhenyu Zheng (zhengzhenyu)
status: New → In Progress
Matt Riedemann (mriedem)
tags: added: api performance
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/539469
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a3a94cf4ec3c0e41ab2a8a66dfc0e7adca2d2a8e
Submitter: Zuul
Branch: master

commit a3a94cf4ec3c0e41ab2a8a66dfc0e7adca2d2a8e
Author: Kevin_Zheng <email address hidden>
Date: Wed Jan 31 16:52:53 2018 +0800

    Improve performance when list instances with IP filter

    When list instances with IP filter, there is no need
    to try to get instances from BuildRequest, as building
    instances will not have IP address. Skip this db call
    can slightly improve performance.

    Closes-Bug: #1764685

    Change-Id: Ic02206e887e3fea7752d615bbed680510c482097

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/563972

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.openstack.org/563972
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bc8c188fc1890d80a1b85866b3d31f51f0aceb38
Submitter: Zuul
Branch: stable/queens

commit bc8c188fc1890d80a1b85866b3d31f51f0aceb38
Author: Kevin_Zheng <email address hidden>
Date: Wed Jan 31 16:52:53 2018 +0800

    Improve performance when list instances with IP filter

    When list instances with IP filter, there is no need
    to try to get instances from BuildRequest, as building
    instances will not have IP address. Skip this db call
    can slightly improve performance.

    Closes-Bug: #1764685

    Change-Id: Ic02206e887e3fea7752d615bbed680510c482097
    (cherry picked from commit a3a94cf4ec3c0e41ab2a8a66dfc0e7adca2d2a8e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.5

This issue was fixed in the openstack/nova 17.0.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0b2

This issue was fixed in the openstack/nova 18.0.0.0b2 development milestone.

Revision history for this message
Matt Riedemann (mriedem) wrote :

I think this might have introduced a regression if you're filtering and have a marker, and that marker is in the build_requests table, we'll then try to find the marker in the cells and fail.

Revision history for this message
Matt Riedemann (mriedem) wrote :

I've reported bug 1777458 for the regression.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.