Replace passing system_metadata to notification functions with instance.system_metadata usage
Bug #1764390 reported by
Balazs Gibizer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
Matt Riedemann |
Bug Description
Both notify_
[1] https:/
[2]https:/
Changed in nova: | |
importance: | Undecided → Low |
tags: | added: notifications |
Changed in nova: | |
status: | New → Triaged |
To post a comment you must log in.
Looking at https:/ /github. com/openstack/ nova/blob/ 57d3b7093259b62 5672a98b0ff4164 3175f6cb82/ nova/compute/ utils.py# L278 it looks like it is used in the case of rebuild:
https:/ /github. com/openstack/ nova/blob/ 57d3b7093259b62 5672a98b0ff4164 3175f6cb82/ nova/compute/ manager. py#L3034
Which comes from conductor:
https:/ /github. com/openstack/ nova/blob/ 57d3b7093259b62 5672a98b0ff4164 3175f6cb82/ nova/conductor/ manager. py#L982
Which comes from the API:
https:/ /github. com/openstack/ nova/blob/ 57d3b7093259b62 5672a98b0ff4164 3175f6cb82/ nova/compute/ api.py# L3080
In case the system_metadata changes because of a new image and it's properties...so I guess we should just remove the comment about being used in the docstring for notify_ usage_exists( ).