xenapi: InstanceNotFound trace in detach_interface during instance delete

[Matt Riedemann]

The xenserver CI n-cpu logs are full of InstanceNotFound tracebacks in detach_interface during what appears to be instance delete, which should be an OK situation that we shouldn't log a traceback ERROR.

http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/37/557837/1/check/dsvm-tempest-neutron-network/86c316e/logs/screen-n-cpu.txt.gz

Mar 29 16:29:49.390491 dsvm-devstack-citrix-mia-nodepool-934537 nova-compute[18313]: ERROR nova.virt.xenapi.vmops [None req-84263977-247f-4c70-9ddf-003680e4eaf8 service nova] [instance: 4e642f5f-abf3-4db9-b630-a1bff1fd1cca] detach network interface 1de85994-b333-4ea1-946b-ce3b11c2f8c5 failed.: InstanceNotFound: Instance instance-00000054 could not be found.
Mar 29 16:29:49.390900 dsvm-devstack-citrix-mia-nodepool-934537 nova-compute[18313]: ERROR nova.virt.xenapi.vmops [instance: 4e642f5f-abf3-4db9-b630-a1bff1fd1cca] Traceback (most recent call last):
Mar 29 16:29:49.391239 dsvm-devstack-citrix-mia-nodepool-934537 nova-compute[18313]: ERROR nova.virt.xenapi.vmops [instance: 4e642f5f-abf3-4db9-b630-a1bff1fd1cca] File "/opt/stack/new/nova/nova/virt/xenapi/vmops.py", line 2696, in detach_interface
Mar 29 16:29:49.391522 dsvm-devstack-citrix-mia-nodepool-934537 nova-compute[18313]: ERROR nova.virt.xenapi.vmops [instance: 4e642f5f-abf3-4db9-b630-a1bff1fd1cca] vm_ref = self._get_vm_opaque_ref(instance)
Mar 29 16:29:49.391802 dsvm-devstack-citrix-mia-nodepool-934537 nova-compute[18313]: ERROR nova.virt.xenapi.vmops [instance: 4e642f5f-abf3-4db9-b630-a1bff1fd1cca] File "/opt/stack/new/nova/nova/virt/xenapi/vmops.py", line 983, in _get_vm_opaque_ref
Mar 29 16:29:49.392067 dsvm-devstack-citrix-mia-nodepool-934537 nova-compute[18313]: ERROR nova.virt.xenapi.vmops [instance: 4e642f5f-abf3-4db9-b630-a1bff1fd1cca] raise exception.InstanceNotFound(instance_id=instance['name'])
Mar 29 16:29:49.392331 dsvm-devstack-citrix-mia-nodepool-934537 nova-compute[18313]: ERROR nova.virt.xenapi.vmops [instance: 4e642f5f-abf3-4db9-b630-a1bff1fd1cca] InstanceNotFound: Instance instance-00000054 could not be found.
Mar 29 16:29:49.393133 dsvm-devstack-citrix-mia-nodepool-934537 nova-compute[18313]: ERROR nova.virt.xenapi.vmops [instance: 4e642f5f-abf3-4db9-b630-a1bff1fd1cca]

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/562838
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5a42701f89a5139acdc38f8572b1083ba528264c
Submitter: Zuul
Branch: master

commit 5a42701f89a5139acdc38f8572b1083ba528264c
Author: Matt Riedemann <email address hidden>
Date: Thu Apr 19 17:42:23 2018 -0400

    xenapi: handle InstanceNotFound in detach_interface()

    CI tests frequently teardown by rolling back interface
    attachments and then deleting the server, both of which
    are asynchronous. If we're trying to detach an interface
    on a guest that is gone, we don't need to log a traceback
    exception in the logs, just let the InstanceNotFound
    raise up to the ComputeManager which will handle the
    error and log it appropriately.

    Change-Id: I9428be0e6e5b640fdda00410817925001361fd2c
    Closes-Bug: #1759979

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/564468

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/564468
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ffe092b112884fda2420ee847128ed975686e8cb
Submitter: Zuul
Branch: stable/queens

commit ffe092b112884fda2420ee847128ed975686e8cb
Author: Matt Riedemann <email address hidden>
Date: Thu Apr 19 17:42:23 2018 -0400

    xenapi: handle InstanceNotFound in detach_interface()

    CI tests frequently teardown by rolling back interface
    attachments and then deleting the server, both of which
    are asynchronous. If we're trying to detach an interface
    on a guest that is gone, we don't need to log a traceback
    exception in the logs, just let the InstanceNotFound
    raise up to the ComputeManager which will handle the
    error and log it appropriately.

    Change-Id: I9428be0e6e5b640fdda00410817925001361fd2c
    Closes-Bug: #1759979
    (cherry picked from commit 5a42701f89a5139acdc38f8572b1083ba528264c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 18.0.0.0b2 development milestone.