archive_deleted_rows --until-complete stops if api database is not configured

[Matt Riedemann]

This change https://review.openstack.org/#/c/515034/ (added in queens) makes the archive_deleted_rows CLI remove instance mappings and request specs from the API database if there are instances archived from the main nova/cell database.

However, with 'superconductor' mode configurations where the cell shouldn't be configured to reach the API database, this will fail, as seen here:

http://logs.openstack.org/71/550171/4/check/nova-next/4986796/logs/devstack-gate-post_test_hook.txt.gz#_2018-03-06_20_44_21_017

So in the case that the API database isn't configured in the nova.conf being used to run the CLI, we should gracefully handle the condition and continue archiving.

I think we could either do this by handling the CantStartEngineError from oslo.db or just check to see if CONF.api_database.connection is set before attempting to hit records in the API DB.

[Surya Seetharaman (tssurya)]

Adapted Solution : Using the CantStartEngineError for handling this gracefully, continuing the archival and informing the user that 0 instance_mappings and 0 request_specs rows were archived because the CONF.api_database.connection was not set.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/550967

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/553742

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550967
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8da6831e6375d013f0235a542b6b91580a43f61f
Submitter: Zuul
Branch: master

commit 8da6831e6375d013f0235a542b6b91580a43f61f
Author: Surya Seetharaman <email address hidden>
Date: Thu Mar 8 19:06:00 2018 +0100

    Make archive_deleted_rows handle a missing CONF.api_database.connection

    This change https://review.openstack.org/#/c/515034/ (added in queens)
    makes the archive_deleted_rows CLI remove instance mappings and request
    specs from the API database if there are instances archived from the
    main nova/cell database. However for this to work, the api database
    connection should be set in the config file. So in the case that the
    API database is not configured in the config file being used to run the
    CLI, we should gracefully handle the condition and and stop archiving thus
    prompting the user to set the api_db config and try the archival operation
    again. This patch fixes the graceful handling.

    Change-Id: I0c7b802a453aa423c7273ab724ce78eac0cfed4c
    Closes-Bug: #1753833

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553742
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=aaae38d1aa227a732b9aa8c93d77a909d0324696
Submitter: Zuul
Branch: stable/queens

commit aaae38d1aa227a732b9aa8c93d77a909d0324696
Author: Surya Seetharaman <email address hidden>
Date: Thu Mar 8 19:06:00 2018 +0100

    Make archive_deleted_rows handle a missing CONF.api_database.connection

    This change https://review.openstack.org/#/c/515034/ (added in queens)
    makes the archive_deleted_rows CLI remove instance mappings and request
    specs from the API database if there are instances archived from the
    main nova/cell database. However for this to work, the api database
    connection should be set in the config file. So in the case that the
    API database is not configured in the config file being used to run the
    CLI, we should gracefully handle the condition and and stop archiving thus
    prompting the user to set the api_db config and try the archival operation
    again. This patch fixes the graceful handling.

    Conflicts:
        nova/tests/unit/test_nova_manage.py

    NOTE(tssurya): The conflict is due to not having changes
    I6f87cf03d49be6bfad2c5e6f0c8accf0fab4e6ee and
    Ibd824a77b32cbceb60973a89a93ce09fe6d1050d in Queens.

    Change-Id: I0c7b802a453aa423c7273ab724ce78eac0cfed4c
    Closes-Bug: #1753833
    (cherry picked from commit 8da6831e6375d013f0235a542b6b91580a43f61f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 18.0.0.0b1 development milestone.