Comment 3 for bug 1746609

Matt Riedemann (mriedem) wrote :

Could be that we don't get here:

https://review.openstack.org/#/c/464008/10/nova/virt/libvirt/config.py@1149

I've also noticed in several places in the libvirt driver and volume code that it expects an entry for connection_info['data']['volume_id'] but that doesn't exist for the storpool volume type, as seen here:

http://logs.ci-openstack.storpool.com/18/539318/1/check/dsvm-tempest-storpool/c3daf58/logs/screen-n-cpu.txt.gz#_Jan_31_18_07_27_971552

The libvirt driver code should probably be falling back to look for the connection_info['serial'] if it can't find the volume_id, since 'serial' is something that nova puts into the connection_info on attach if it's not already there:

https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L425