allocation candidates db backend can handle traits but the HTTP front end is not turned on

Bug #1743860 reported by Chris Dent
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Undecided
Unassigned

Bug Description

The code for /allocation_candidates is set up to be able to process a 'required' parameter alongside the 'resources' parameter. This results in a collection of RequestGroups which are used by the AllocationCandidates code in nova/objects/resource_provider.py

But we can't request traits on /allocation_candidates because the json schema does not allow the 'required' parameter.

Adding that results in a system that appears to work modulo at least one issue:

* AllocationCandidates._get_by_requests raised ValueError on an unknown trait. It should probably raise TraitNotFound, which should be caught in the allocation_candidates handler. (There's also a raw ValueError related to sharing providers).

Of course this doesn't address the nested situation, but that's in progress elsewhere.

I have some wip code that demonstrates making it work, others should feel free to leap on this though as I will be out of touch for the next 4 days.

Tags: placement
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/534886

Chris Dent (cdent)
summary: - allocation candidates db backend can handle non-nested traits but the
- HTTP front end is not turned on
+ allocation candidates db backend can handle traits but the HTTP front
+ end is not turned on
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Chris Dent (<email address hidden>) on branch: master
Review: https://review.openstack.org/534886
Reason: Alex is doing this properly at Change-Id: Id821b5b2768dcc698695ba6570c6201e1e9a8233

Revision history for this message
Chris Dent (cdent) wrote :

Apparently this was mostly expected, but not fully documented, so going to invalidate the bug.

https://review.openstack.org/#/c/535642/

Changed in nova:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers