don't call sync_guest_time if qga is not enabled

Bug #1738997 reported by Chen Hanxiao on 2017-12-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Undecided
Chen Hanxiao

Bug Description

Description
===========

sync_guest_time relies on qemu guest agent.

If hw_qemu_guest_agent is not set, we'll get:

DEBUG nova.virt.libvirt.guest Failed to set time: agent not configured

if sync_guest_time is called.

We could improve this by checking whether qga is enabled,
other than call libvirt and catch a exception.

Steps to reproduce
==================
1) start a VM without hw_qemu_geust_agent
2) pause that VM then unpause
3) check the log of nova-compute

Expected result
===============
No related logs

Actual result
=============
Got a error log: Failed to set time: agent not configured

Changed in nova:
assignee: nobody → Chen Hanxiao (chenhanxiao)
Changed in nova:
status: New → In Progress
Changed in nova:
assignee: Chen Hanxiao (chenhanxiao) → Stephen Finucane (stephenfinucane)
Changed in nova:
assignee: Stephen Finucane (stephenfinucane) → Chen Hanxiao (chenhanxiao)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers