api-ref: parameters in servers.inc should be verified

Bug #1738930 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Takashi Natsume

Bug Description

In api-ref/source/servers.inc, there is a following description.
Parameter verification has not been finished yet.
So parameters should be verified.

.. TODO(sdague) parameter microversions need to be gone through in the
   response (request side should be good)

https://raw.githubusercontent.com/openstack/nova/07c925a5321e379293bbf0e55bf3c40798eaf21b/api-ref/source/servers.inc

Tags: api-ref
Revision history for this message
Takashi Natsume (natsume-takashi) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/550648

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/550659

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/528201
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=56283f167dc97c2c93adc65d5a4d2a53d1471f6e
Submitter: Zuul
Branch: master

commit 56283f167dc97c2c93adc65d5a4d2a53d1471f6e
Author: Takashi NATSUME <email address hidden>
Date: Thu Mar 8 09:05:16 2018 +0900

    api-ref: Parameter verification for servers.inc (1/3)

    This patch verifies query parameters.
    Subsequent patches will verify other parameters.

    Change-Id: I6078c0c8ebc888dc120f446f228a3b0433b89a76
    Partial-Bug: #1738930

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/550648
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bab3184ced29ef8333cdd4d1cf6caf0b4226a1d4
Submitter: Zuul
Branch: master

commit bab3184ced29ef8333cdd4d1cf6caf0b4226a1d4
Author: Takashi NATSUME <email address hidden>
Date: Thu Mar 8 09:21:13 2018 +0900

    api-ref: Parameter verification for servers.inc (2/3)

    This patch verifies BDM, fault and scheduler hint parameters.
    A subsequent patch will verify other parameters.

    Change-Id: If57aa3e37ebaa6fa13718480bb216d10664aa5b1
    Partial-Bug: #1738930

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/550659
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=39fbcfd51812e07c1132321933633bd8804a85e4
Submitter: Zuul
Branch: master

commit 39fbcfd51812e07c1132321933633bd8804a85e4
Author: Takashi NATSUME <email address hidden>
Date: Thu Mar 8 10:09:25 2018 +0900

    api-ref: Parameter verification for servers.inc (3/3)

    This patch completes parameter verification for servers.inc.

    * Verifies remaining parameters
    * Sorts parameters
    * Adds missing parameters
    * Removing unncessary parameters

    Change-Id: If01b2dcfa9df8c0e80ad1da65115204fe321891b
    Closes-Bug: #1738930

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0b1

This issue was fixed in the openstack/nova 18.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.