Normal response code of addSecurityGroup is wrong

[hongbin]

Description
===========
According to nova's api-ref [1], the normal response code of addSecurityGroup is 202. However, according to OpenStack API guideline [2] , 202 is for "Asynchronous resource creation" but the addSecurityGroup action doesn't seem to be async. I think 200 is more appropriate in this case.

[1] https://developer.openstack.org/api-ref/compute/#add-security-group-to-a-server-addsecuritygroup-action
[2] http://specs.openstack.org/openstack/api-wg/guidelines/http.html#xx-success-codes

[jichenjc (jichenjc)]

guess we can modify all this kind of 20x return code in one patch with microversion bump... (if you search in the code, there are more like this)

[Deepak Mourya (mourya007)]

yes remove security group [1] also using the same thing

[1] https://github.com/openstack/nova/blob/3800cf6ae2a1370882f39e6880b7df4ec93f4b93/nova/api/openstack/compute/security_groups.py#L459

[Ghanshyam Mann (ghanshyammann)]

Yea, there are lot of other place where API status code are not consistent and as per guidelines. As jichenjc mentioned this will be API change and need microversion bump to maintain the backward compatibility.

And as per Nova process, every API change needs spec, so please write spec for this for further discussion.

[Ghanshyam Mann (ghanshyammann)]

marking as invalid as this is more API change request which need spec than bug. feel free to propose the API spec for same.