Ironic nodes report CUSTOM_CUSTOM_FOO resource class

Bug #1724524 reported by John Garbutt
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Won't Fix

Bug Description

Currently if you set CUSTOM_FOO in ironic, the virt driver now sends CUSTOM_CUSTOM_FOO to placement.

Really we shouldn't force users to drop the CUSTOM_ inside ironic.

User sets CUSTOM_FOO in ironic.
Placement shows CUSTOM_FOO resources.

Placement shows CUSTOM_CUSTOM_FOO resources

Tags: placement
Changed in nova:
assignee: nobody → John Garbutt (johngarbutt)
status: New → In Progress
importance: Undecided → High
tags: added: placement
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master

Matt Riedemann (mriedem)
no longer affects: nova/ocata
Changed in nova:
assignee: John Garbutt (johngarbutt) → Matt Riedemann (mriedem)
Revision history for this message
Matt Riedemann (mriedem) wrote :

Being discussed, this might not be a bug.

Changed in nova:
assignee: Matt Riedemann (mriedem) → John Garbutt (johngarbutt)
Revision history for this message
John Garbutt (johngarbutt) wrote :

This is considered as designed, so will not be fixed.

It complicates the general case of mapping from ironic resource classes to placement resource classes.

I still think this is going to trip up many Ironic administrators. The docs are not clear that CUSTOM_FOO maps to CUSTOM_CUSTOM_FOO.

no longer affects: nova/pike
Changed in nova:
status: In Progress → Won't Fix
assignee: John Garbutt (johngarbutt) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Submitter: Zuul
Branch: master

commit f73d6eb1dc928c811231e059f293901405bed1ee
Author: John Garbutt <email address hidden>
Date: Wed Oct 18 11:47:49 2017 +0100

    Add test so we remember why CUSTOM_ prefix added

    While it is tempting as an ironic operator to have CUSTOM_FOO in
    placement, nova flavors and ironic resource class attributes,
    allow that makes for a more complicated mapping between ironic
    resource classes and the resource classes in the general case,
    and could cause confusion when there is a typo of CUSTOM vs CUSTM
    that could get mapped very differently into placement.

    Adding this test so it is clear this is a deliberate choice, and
    git blame will find this git commit message.

    Related-Bug: #1724524

    Change-Id: Ie38baea53e41ca7ba8875fd113cd777810f17db7

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.