(perf) Unnecessarily joining instance.services when listing instances regardless of microversion
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Andrey Volkov | ||
Pike |
Confirmed
|
Medium
|
Unassigned | ||
Queens |
Fix Committed
|
Medium
|
Matt Riedemann |
Bug Description
Microversion 2.16 adds the ability to show the host status of an instance when listing servers with details or showing a single server's details. By default that is only shown for an admin.
Change https:/
However, that check is not based on version 2.16, like the 2.26 tags check below it.
This means that we are unnecessarily joining with the services table when querying instances with microversions < 2.16, which happens, for example, by default in the openstack CLI which uses microversion 2.1.
We arguably should make this also conditional on policy so we don't join for non-admins by default, but that's less of an issue probably as non-admins probably aren't listing thousands of instances from the deployment like an admin would.
summary: |
- instance.services loading when listing instances regardless of - microversion + (perf) Unnecessarily joining instance.services when listing instances + regardless of microversion |
Changed in nova: | |
assignee: | Andrey Volkov (avolkov) → jichenjc (jichenjc) |
status: | Triaged → In Progress |
Changed in nova: | |
assignee: | jichenjc (jichenjc) → Matt Riedemann (mriedem) |
Changed in nova: | |
assignee: | Matt Riedemann (mriedem) → nobody |
assignee: | nobody → Andrey Volkov (avolkov) |
Related patch: https:/ /review. openstack. org/#/c/ 507854/