config option help for default value of default_publisher_id is wrong

[Matt Riedemann]

The config option help for "default_publisher_id" says the default value is "$my_ip" but that's not what's actually used:

        notifier = rpc.get_notifier('api', publisher_id=(
            CONF.notifications.default_publisher_id or CONF.host))

and:

    if not publisher_id:
        publisher_id = "%s.%s" % (service, host or CONF.host)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/498094

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/498094
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=27cd4dd70b5a51919ce0091ab4247f65e5a27526
Submitter: Jenkins
Branch: master

commit 27cd4dd70b5a51919ce0091ab4247f65e5a27526
Author: Matt Riedemann <email address hidden>
Date: Fri Aug 25 17:13:48 2017 -0400

    Change default for [notifications]/default_publisher_id to $host

    The default used in code for CONF.notifications.default_publisher_id
    is CONF.host, which is a free-form StrOpt.

    In an upcoming change, the "my_ip" option is going to be changed from
    a StrOpt to an IPOpt, so we made the default value change for
    the default_publisher_id option before that.

    Change-Id: Ia85130f66bd5a60097e8967064559fd0962d06fd
    Closes-Bug: #1713150

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b1 development milestone.