nova doesn't clean up the resources after live migrate

[Lajos Katona]

The following scenario doesn't work with nova migrate:
* Boot a VM.
* live migrate the VM.
* check the allocations:
** there are double allocations
** the allocations are claimed for both the source and destination host of the migration.

nova commit on which the test happened: 08ec8a1ad3f3492b99db48d9e8fa132cb1bb3e8c

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/495811

[Matt Riedemann (mriedem)]

Looks similar to what was needed for removing the allocations for an instance on the source node in an evacuate operation:

https://review.openstack.org/#/c/494625/1/nova/compute/manager.py

[Matt Riedemann (mriedem)]

To be clear, the bug here is that the allocations are not cleaned up from the source node once the migration is complete.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/496032

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/496202

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/495811
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1ce7a136b362fbfb2d3d231ba8e1cd77081139ce
Submitter: Jenkins
Branch: master

commit 1ce7a136b362fbfb2d3d231ba8e1cd77081139ce
Author: Lajos Katona <email address hidden>
Date: Mon Aug 21 12:27:09 2017 +0200

    Add functional live migrate test

    Live migration now seems to be failing, as after the movement of the VM,
    the allocations are both present on the source host, and on the
    destination host.
    The related assertions are commented out and replaced with wrong ones to
    make the test pass.

    Change-Id: Ib15d34c8da14dd006a0782e325d3c5e7b83fd0f1
    Related-Bug: #1712045

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/496726

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/496728

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/496032
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=72728ed01fe5d568855ad92596740a2da81169c4
Submitter: Jenkins
Branch: master

commit 72728ed01fe5d568855ad92596740a2da81169c4
Author: Dan Smith <email address hidden>
Date: Mon Aug 21 15:44:42 2017 -0700

    Remove source node allocation after live migration completes

    This is done in a similar way to evacuation and shelve offload
    to avoid further mingling of new-style allocation management
    code with existing resource tracker code (soon to be removed).

    Closes-Bug: #1712045
    Change-Id: I6afd69166704e45d983b8b06a32a2799fb82b58a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/496726
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f2f967b403ab1225c5ccb39bb52977748ebbd32d
Submitter: Jenkins
Branch: stable/pike

commit f2f967b403ab1225c5ccb39bb52977748ebbd32d
Author: Lajos Katona <email address hidden>
Date: Mon Aug 21 12:27:09 2017 +0200

    Add functional live migrate test

    Live migration now seems to be failing, as after the movement of the VM,
    the allocations are both present on the source host, and on the
    destination host.
    The related assertions are commented out and replaced with wrong ones to
    make the test pass.

    Change-Id: Ib15d34c8da14dd006a0782e325d3c5e7b83fd0f1
    Related-Bug: #1712045
    (cherry picked from commit 1ce7a136b362fbfb2d3d231ba8e1cd77081139ce)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/496728
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d041569ad540e9eb57eeaf5b20df4c8bde8b189f
Submitter: Jenkins
Branch: stable/pike

commit d041569ad540e9eb57eeaf5b20df4c8bde8b189f
Author: Dan Smith <email address hidden>
Date: Mon Aug 21 15:44:42 2017 -0700

    Remove source node allocation after live migration completes

    This is done in a similar way to evacuation and shelve offload
    to avoid further mingling of new-style allocation management
    code with existing resource tracker code (soon to be removed).

    Closes-Bug: #1712045
    Change-Id: I6afd69166704e45d983b8b06a32a2799fb82b58a
    (cherry picked from commit 72728ed01fe5d568855ad92596740a2da81169c4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/496202
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=633ebd1e9b057f0614961d79391987b51bb5d5a0
Submitter: Jenkins
Branch: master

commit 633ebd1e9b057f0614961d79391987b51bb5d5a0
Author: Lajos Katona <email address hidden>
Date: Tue Aug 22 12:53:07 2017 +0200

    Add functional migrate force_complete test

    This patch adds test that checkes that the resource allocation is properly
    handled during live migration force complete.

    Co-Authored-By: Dan Smith <email address hidden>
    Related-Bug: #1712045
    Change-Id: If958e64eda1260a8dd08078de2dae167c6a147bc

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/509924

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/509924
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f9ee18e90cca226b5bf90b3b26fbc8e17228f55c
Submitter: Zuul
Branch: stable/pike

commit f9ee18e90cca226b5bf90b3b26fbc8e17228f55c
Author: Lajos Katona <email address hidden>
Date: Tue Aug 22 12:53:07 2017 +0200

    Add functional migrate force_complete test

    This patch adds test that checkes that the resource allocation is properly
    handled during live migration force complete.

    Co-Authored-By: Dan Smith <email address hidden>
    Related-Bug: #1712045
    Change-Id: If958e64eda1260a8dd08078de2dae167c6a147bc
    (cherry picked from commit 633ebd1e9b057f0614961d79391987b51bb5d5a0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b1 development milestone.