Ironic Flavor Migration can miss instances

[Ed Leafe]

The recently merged patch (https://review.openstack.org/484949) runs the migration in the driver's init_host() method. It has since been pointed out that if there are multiple computes handling ironic, some instances can get skipped if the hash ring is refreshed and an unmigrated instance is placed on a compute whose init_host has already run. While a rare thing, this should be corrected to ensure that all instances have their flavors migrated in Pike.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/487954

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/493227

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/487954
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c3118b91db4b97a689c9a2f25a9554a0ccb29252
Submitter: Jenkins
Branch: master

commit c3118b91db4b97a689c9a2f25a9554a0ccb29252
Author: EdLeafe <email address hidden>
Date: Wed Jul 26 23:07:38 2017 +0000

    Handle addition of new nodes/instances in ironic flavor migration

    The original idea for ironic flavor migration was to handle it in
    init_host(), so that the code wouldn't run often. But in a situation
    like an upgrade with multiple Nova computes handling ironic nodes, this
    may not cover all the nodes, so we are moving it to be run whenever the
    cache is refreshed, and new nodes for the compute service that have
    instances are detected. We also need to cover the cases where an
    existing node has a new instance created on it to ensure that that new
    instance's flavor is also migrated.

    Closes-Bug: #1707021

    Change-Id: If0a7af3a958cf3aba95b89b96df5ff6bf252b110

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/493227
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=322a99db22fce1548358514500f2152fcc32622c
Submitter: Jenkins
Branch: stable/pike

commit 322a99db22fce1548358514500f2152fcc32622c
Author: EdLeafe <email address hidden>
Date: Wed Jul 26 23:07:38 2017 +0000

    Handle addition of new nodes/instances in ironic flavor migration

    The original idea for ironic flavor migration was to handle it in
    init_host(), so that the code wouldn't run often. But in a situation
    like an upgrade with multiple Nova computes handling ironic nodes, this
    may not cover all the nodes, so we are moving it to be run whenever the
    cache is refreshed, and new nodes for the compute service that have
    instances are detected. We also need to cover the cases where an
    existing node has a new instance created on it to ensure that that new
    instance's flavor is also migrated.

    Closes-Bug: #1707021

    Change-Id: If0a7af3a958cf3aba95b89b96df5ff6bf252b110
    (cherry picked from commit c3118b91db4b97a689c9a2f25a9554a0ccb29252)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b1 development milestone.