max_version is wrong for os-quota-class-sets api reference

Bug #1705115 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Matt Riedemann

Bug Description

The network related resources that are deprecated in the os-quota-class-sets API is specifying the wrong version:

https://developer.openstack.org/api-ref/compute/?expanded=show-the-quota-for-quota-class-detail#show-the-quota-for-quota-class

That says those are deprecated in 2.50 but should say they are deprecated in 2.49. That was added here:

https://review.openstack.org/#/c/483170/

It's a bit confusing, but max_version means the highest possible version that would work with the request, just like in the API code itself. So we should change those to max_version: 2.49 as that's the last version you can get the network related resources in the os-quota-class-sets API response (or specify them in the request).

Tags: api-ref
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/484952

Changed in nova:
assignee: nobody → Matt Riedemann (mriedem)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/484952
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=90c6e256b83e03369c966ded3470655121c94048
Submitter: Jenkins
Branch: master

commit 90c6e256b83e03369c966ded3470655121c94048
Author: Matt Riedemann <email address hidden>
Date: Tue Jul 18 17:15:49 2017 -0400

    api-ref: fix max_version for deprecated os-quota-class-sets parameters

    The max_version on the fixed_ips, floating_ips, networks,
    security_groups and security_group_members parameters for the
    os-quota-class-sets API should be capped at 2.49, not 2.50.

    This is a bit confusing but it works the same as max_version
    works in the API code, i.e. the max version is the highest
    version you can request that parameter on that API and it
    will work. 2.50 was wrong because in 2.50 we don't accept
    or return those parameters.

    This is similar to the network-related resource deprecation
    in the os-quota-sets API with the 2.36 microversion. The API
    reference for those parameters in os-quota-sets use
    max_version: 2.35.

    Change-Id: Ib3e3cdc1ba57172fce1b03a0e77302c3edf9f0dc
    Closes-Bug: #1705115

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b3

This issue was fixed in the openstack/nova 16.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.