VMware: Concurrent nova-compute service initialization may fail

[Radoslav Gerganov]

During initialization, the VMware Nova compute driver checks whether a VC extension with key 'org.openstack.compute' exists and if not, it registers one. This is a race condition. If multiple services try to register the same extension, only one of them will succeed. The fix is to catch InvalidArgument fault from vSphere API and ignore the exception.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/484667

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/484667
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=46c7fa492ffbef35f7292775eaa50fc62f290e54
Submitter: Zuul
Branch: master

commit 46c7fa492ffbef35f7292775eaa50fc62f290e54
Author: Radoslav Gerganov <email address hidden>
Date: Tue Jul 18 11:18:42 2017 +0300

    VMware: Handle concurrent registrations of the VC extension

    During initialization, the Nova compute driver checks whether a
    vCenter extension with key 'org.openstack.compute' exists and if
    not, it registers one. This is a race condition. If multiple
    services try to register the same extension, only one of them
    will succeed. The fix is to catch InvalidArgument fault from
    vSphere API and ignore the exception.

    Change-Id: I92c24709a2f55b601c31a31b9e748f19e7e31984
    Closes-Bug: #1704952

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b2 development milestone.