publisher_id of the versioned instance.update notification is not consistent with other notifications

Bug #1702667 reported by Balazs Gibizer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Balazs Gibizer

Bug Description

Description
===========
The publisher_id of the versioned instance.update notification contains 'conductor' as the source of the notification but every other versioned notification use names like 'nova-compute', 'nova-api', 'nova-scheduler'. This makes the notification interface slightly inconsistent.

Steps to reproduce
==================
* boot a new instance
* check the publisher_id of instance.update notification

Expected result
===============
publisher_id contains 'nova-conductor'

Actual result
=============
publisher_id contains 'conductor'

Environment
===========
devstack with nova master dbf5fdb156f01196e8994798e8eea7e6b0926697
or
nova in tree functional test: https://github.com/openstack/nova/blob/24b275756e2ab5f7b1bcf1f31de09d28329eef3f/nova/tests/functional/notification_sample_tests/test_instance.py#L234

Changed in nova:
assignee: nobody → Balazs Gibizer (balazs-gibizer)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/480984

Changed in nova:
status: New → In Progress
tags: added: notifications
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/480984
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=427f4ec430612c4679b1b9c300e1ca785c8e928d
Submitter: Jenkins
Branch: master

commit 427f4ec430612c4679b1b9c300e1ca785c8e928d
Author: Balazs Gibizer <email address hidden>
Date: Thu Jul 6 12:55:37 2017 +0200

    Make notification publisher_id consistent

    The publisher_id of the versioned instance.update notification contains
    'conductor' as the source of the notification but every other versioned
    notification use names like 'nova-compute', 'nova-api',
    'nova-scheduler'. This patch fixes this inconsistency.

    Change-Id: I61c1d1676e74e367b4aeef6a6d3a7bb2ffacee23
    Closes-Bug: #1702667

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b3

This issue was fixed in the openstack/nova 16.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.