MISC_SHARES_VIA_AGGREGATE not found still show up in the functional test

[Alex Xu]

After the patch https://review.openstack.org/475448 merged. The trait MISC_SHARES_VIA_AGGREGATE still may not found in the functional test, even with the fix https://review.openstack.org/478564.

One of case:
http://logs.openstack.org/85/330285/83/check/gate-nova-tox-functional-py35-ubuntu-xenial/94a3627/testr_results.html.gz

29 hits:
http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22%2Fusr%2Flocal%2Fbin%2Fdevstack-version:%20line%203:%20unexpected%20EOF%20while%20looking%20for%20matching%20%60''%5C%22%20AND%20tags:%5C%22console%5C%22&from=7d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/480198

[Sylvain Bauza (sylvain-bauza)]

That's weird because the gate got os-traits==0.3.1 [1] which already provides that trait [2]

[1]http://logs.openstack.org/85/330285/83/check/gate-nova-tox-functional-py35-ubuntu-xenial/94a3627/console.html#_2017-07-04_11_25_02_155233

[2]https://github.com/openstack/os-traits/blob/0.3.1/os_traits/misc/__init__.py

Looks like a problem when synchronizing the os-traits lib, investigating.

[Sylvain Bauza (sylvain-bauza)]

I was able to reproduce locally the bug. After comparing 2 runs, one working and the other not, I think the problem is related to the traits functional tests being verified before that one.

http://paste.openstack.org/show/614397/

[Sylvain Bauza (sylvain-bauza)]

Confirmed, running the same list of tests without the nova.tests.functional.api.openstack.placement.test_placement_api.traits tests makes the run successful.

http://paste.openstack.org/show/614398/

[Sylvain Bauza (sylvain-bauza)]

Ha, think I found the problem. We fixed the problem for tests inheriting from TestCase [1], but given the SharedStorageFixture just uses the GabbiFixture, when cleaning up the DB we remove the traits as well.

[1]https://review.openstack.org/#/c/478564/2

[Sylvain Bauza (sylvain-bauza)]

The Logstash query was wrong, this is the good one:
http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22'nova.exception.TraitNotFound%3A%20No%20such%20trait%20MISC_SHARES_VIA_AGGREGATE.%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d

Raising the priority as it impacts the gate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480198
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=07d82cf8ef47d249193b2cb16fd13a94a5678468
Submitter: Jenkins
Branch: master

commit 07d82cf8ef47d249193b2cb16fd13a94a5678468
Author: Sylvain Bauza <email address hidden>
Date: Tue Jul 4 18:40:39 2017 +0200

    Reset the traits sync flag in the placement fixtures

    We had a problem with tests running that were unable to find traits because a
    previous test cleaned up the DB without resetting the sync flag and we fixed
    that in I5dc0220310986c5b9fe5b71013c573c3d98cb9aa

    Unfortunately, fixtures we use in Placement functional tree don't inherit from
    general test cases (for obvious reasons) so we need to also reset the flag
    there.

    Co-Authored-By: Sylvain Bauza <email address hidden>

    Change-Id: Ib7019db36ce90bf6d762a6d37697c3a215e091b4
    Closes-Bug: #1702304

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.0.0b3 development milestone.