Misuse of assertIsNone in tests

Bug #1699927 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Takashi Natsume
Ocata
Fix Committed
Medium
Takashi Natsume
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/476736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/476736
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a50d21662e121c50457f3154200845450e2af301
Submitter: Jenkins
Branch: master

commit a50d21662e121c50457f3154200845450e2af301
Author: Takashi NATSUME <email address hidden>
Date: Fri Jun 23 09:39:56 2017 +0900

    Fix misuse of assertIsNone

    Change-Id: If86f954a37c6c9e5d637db9f7d8d80e40d3b0fc9
    Closes-Bug: #1699927

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/477044

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b3

This issue was fixed in the openstack/nova 16.0.0.0b3 development milestone.

Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
Claudiu Belu (cbelu) wrote :

Interesting. It seems we have some hacking rule against stuff like this, which seems to be ignored:

    def assert_equal_none(logical_line):
    """Check for assertEqual(A, None) or assertEqual(None, A) sentences

    N318
    """

There are plenty of other misuses of assertIsNone too. Something like this should be fixed in master properly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/477044
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2ea000061c571101ec604dd47425d7b32ee1e01b
Submitter: Jenkins
Branch: stable/ocata

commit 2ea000061c571101ec604dd47425d7b32ee1e01b
Author: Takashi NATSUME <email address hidden>
Date: Fri Jun 23 09:39:56 2017 +0900

    Fix misuse of assertIsNone

    Change-Id: If86f954a37c6c9e5d637db9f7d8d80e40d3b0fc9
    Closes-Bug: #1699927
    (cherry picked from commit a50d21662e121c50457f3154200845450e2af301)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 15.0.7

This issue was fixed in the openstack/nova 15.0.7 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.