api-ref: GET /os-hypervisors/{hypervisor_hostname_pattern}/search response parameter hypervisor_hostname description is wrong

Bug #1698000 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Matt Riedemann

Bug Description

The docs say:

https://developer.openstack.org/api-ref/compute/?expanded=search-hypervisor-detail#search-hypervisor

"The hypervisor host name provided by the Nova virt driver. For the Ironic driver, it is the Ironic node name."

However, for Ironic, the hypervisor_hostname is the Ironic node uuid, not the name:

https://github.com/openstack/nova/blob/b94b02b4503cf7eded3fafb84c436395d4beb6ec/nova/virt/ironic/driver.py#L332

Tags: api-ref
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/474723

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/474723
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b541f71d0f4c9fec1453342b3a89f8c02f684746
Submitter: Jenkins
Branch: master

commit b541f71d0f4c9fec1453342b3a89f8c02f684746
Author: Matt Riedemann <email address hidden>
Date: Thu Jun 15 14:20:15 2017 -0400

    api-ref: fix hypervisor_hostname description for Ironic

    The hypervisor_hostname shown in the os-hypervisors and servers
    APIs is actually the Ironic node uuid, not a name. This comes
    from the Ironic virt driver _node_resource method which eventually
    gets used in the resource tracker to set the ComputeNode
    hypervisor_hostname field, which is used to also set the instance.node
    value in the ResourceTracker later during the instance claim.

    The confusion probably lies in the fact that the variable passed
    around the code is also referred to as "nodename", but in the case
    of Ironic it's not actually a hostname, it's a uuid.

    Change-Id: Ic639abe9989b282bad71581bb861314619c0f48b
    Closes-Bug: #1698000

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b3

This issue was fixed in the openstack/nova 16.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.