resource provider links list shows 'traits' in all microversions and should not

Bug #1693353 reported by Chris Dent
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Chris Dent

Bug Description

When listing single or multiple resource providers, the JSON response includes a list of 'links' with each provider. These link to 'inventories', 'aggregates', 'usages' and 'traits'. Since 'traits' only showed up in microversion 1.6 the link to them should only be presented if the microversion is 1.6 or above.

The change to fix this is in the '_serialize_links' method in nova.api.openstack.placement.handlers.resource_provider.

Tags: placement
Chris Dent (cdent)
Changed in nova:
assignee: nobody → Chris Dent (cdent)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/468923

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/468923
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=72960a33e094f74de76f23d75dbaaae07332fa6f
Submitter: Jenkins
Branch: master

commit 72960a33e094f74de76f23d75dbaaae07332fa6f
Author: Chris Dent <email address hidden>
Date: Mon May 29 16:38:59 2017 +0000

    [placement] adjust resource provider links by microversion

    The resource provider representation includes links to other related
    resources. Those links should vary depending on microversion as some
    of the related resources did not show up until a later microversion.

    This change makes it so 'aggregates' show up at microverison 1.1 and
    beyond and traits in microversion 1.6 and beyond. A new gabbit has
    been added, resource-provider-links which exercises this. Only the
    single resource provider representation is tested because the same
    code is used for single and collection representations.

    Change-Id: Ife64922ee91a775fabdcf718e6eb0e0c7ddfde7a
    Closes-Bug: #1693353

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b2

This issue was fixed in the openstack/nova 16.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.