Spurious "Received unexpected event network-vif-unplugged" warnings in n-cpu logs

[Matt Riedemann]

In a normal tempest dsvm full CI job run we see at least 19 occurrences of this warning in the n-cpu logs:

http://logs.openstack.org/64/458564/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/e5f9b92/logs/screen-n-cpu.txt.gz?level=TRACE#_May_07_20_08_38_082712

May 07 20:08:38.082712 ubuntu-xenial-osic-cloud1-s3500-8755125 nova-compute[23037]: WARNING nova.compute.manager [req-22e142af-e20a-4cd5-b9c8-6f757330f225 service nova] [instance: 705953fc-02f1-4c51-a6eb-627adff91d1b] Received unexpected event network-vif-unplugged-653e2f64-82ec-45fa-bfc6-c77293220be3 for instance

If the instance is being deleted and we're just racing with neutron sending the network-vif-unplugged event before the instance is actually deleted, then it's not really unexpected and we shouldn't log a warning for this. We can probably check the instance task_state to see if it's being deleted and adjust the log level accordingly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/465794

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/465794
Reason: This review is > 4 weeks without comment, and is not mergable in it's current state. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465794
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=97e3cb891abd685e2dcb187deb34202a4ed251b2
Submitter: Jenkins
Branch: master

commit 97e3cb891abd685e2dcb187deb34202a4ed251b2
Author: Matt Riedemann <email address hidden>
Date: Tue Aug 1 09:05:30 2017 -0400

    Don't warn on expected network-vif-unplugged events

    If we're getting a network-vif-unplugged event because we're
    deleting an instance, and part of that is unplugging vifs,
    then we don't need to log a warning about it since it's expected.

    This could be true of other tasks like migrations, but we're
    starting small here. So for now, if we log a warning, this change
    also includes the vm_state and task_state in the warning to help
    us discover what else we can expect.

    Change-Id: I080075fa543bd1ca4fa57580583bda6d3847bf9c
    Closes-Bug: #1691615

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b1 development milestone.