Error on adding duplicated secgroup

[hongbin]

Steps to reproduce:

openstack server create --flavor m1.tiny --security-group default --image cirros-0.3.5-x86_64-disk myinstance
$ openstack server add security group myinstance default
Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.
<class 'neutronclient.common.exceptions.BadRequest'> (HTTP 500) (Request-ID: req-b5f07687-7b4d-4ff3-90b4-0835dbeef9c4)

The error in n-api: http://paste.openstack.org/show/609722/

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

[hongbin (hongbin034)]

Here you go: https://review.openstack.org/#/c/465173/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465173
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=083bc89f99e007c400b9f89c63ac0459da910df8
Submitter: Zuul
Branch: master

commit 083bc89f99e007c400b9f89c63ac0459da910df8
Author: Hongbin Lu <email address hidden>
Date: Tue May 16 20:54:25 2017 +0000

    Handle exception on adding secgroup

    If user adds security group to an instance and the instance already
    has that security group, neutron will return a 400 response. Nova
    should handle the 400 response properly. In before, Nova doesn't
    seem to handle this case and end-user gets a 500 response. This
    commit fixed it.

    Closes-Bug: #1691274
    Change-Id: I58b19ef6b537d690df90e542b6af3c64773ecc87

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/515418

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/515421

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/515418
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fe9192037c2db49393e2e5f4e1c088ad7c38215f
Submitter: Zuul
Branch: stable/pike

commit fe9192037c2db49393e2e5f4e1c088ad7c38215f
Author: Hongbin Lu <email address hidden>
Date: Tue May 16 20:54:25 2017 +0000

    Handle exception on adding secgroup

    If user adds security group to an instance and the instance already
    has that security group, neutron will return a 400 response. Nova
    should handle the 400 response properly. In before, Nova doesn't
    seem to handle this case and end-user gets a 500 response. This
    commit fixed it.

    Conflicts:
          nova/network/security_group/neutron_driver.py

    NOTE(hongbin): The conflict is due to the removal of translation of
    log messages.

    Closes-Bug: #1691274
    Change-Id: I58b19ef6b537d690df90e542b6af3c64773ecc87
    (cherry picked from commit 083bc89f99e007c400b9f89c63ac0459da910df8)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/515421
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1d614443a7198642ef14467ab470ce1aa41f36b9
Submitter: Zuul
Branch: stable/ocata

commit 1d614443a7198642ef14467ab470ce1aa41f36b9
Author: Hongbin Lu <email address hidden>
Date: Tue May 16 20:54:25 2017 +0000

    Handle exception on adding secgroup

    If user adds security group to an instance and the instance already
    has that security group, neutron will return a 400 response. Nova
    should handle the 400 response properly. In before, Nova doesn't
    seem to handle this case and end-user gets a 500 response. This
    commit fixed it.

    Conflicts:
          nova/network/security_group/neutron_driver.py

    NOTE(hongbin): The conflict is due to the removal of translation of
    log messages.

    Closes-Bug: #1691274
    Change-Id: I58b19ef6b537d690df90e542b6af3c64773ecc87
    (cherry picked from commit 083bc89f99e007c400b9f89c63ac0459da910df8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.1.1 release.