cpu_realtime_mask handling is not intuitive

Bug #1688673 reported by Chris Friesen on 2017-05-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Wishlist
Stephen Finucane

Bug Description

The nova code implicitly assumes that all vCPUs are realtime in nova.virt.hardware.vcpus_realtime_topology(), and then it appends the user-specified mask.

This only makes sense if the user-specified cpu_realtime_mask is an exclusion mask, but this isn't documented anywhere.

It would make more sense to simply use the mask as passed-in from the end-user.

In order to preserve the current behaviour we should probably special-case the scenario where the passed-in cpu_realtime_mask starts with a "^" (indicating an exclusion).

Chris Friesen (cbf123) on 2017-05-05
description: updated
Changed in nova:
assignee: nobody → Chris Friesen (cbf123)
status: New → In Progress
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

Changed in nova:
status: In Progress → New
assignee: Chris Friesen (cbf123) → nobody
Chris Friesen (cbf123) wrote :

There is an open review for this bug, don't know why the link wasn't added:

https://review.openstack.org/#/c/461456/

Changed in nova:
assignee: nobody → Chris Friesen (cbf123)
Sean Dague (sdague) on 2017-06-23
Changed in nova:
status: New → In Progress
importance: Undecided → Wishlist
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in nova:
status: In Progress → New
assignee: Chris Friesen (cbf123) → nobody
Sean Dague (sdague) on 2017-06-27
Changed in nova:
status: New → In Progress
assignee: nobody → Chris Friesen (cbf123)
Sean Dague (sdague) on 2017-06-27
Changed in nova:
status: In Progress → Confirmed
Sean Dague (sdague) on 2017-06-27
Changed in nova:
status: Confirmed → In Progress

Change abandoned by Chris Friesen (<email address hidden>) on branch: master
Review: https://review.openstack.org/461456
Reason: Abandoning this patch to instead add a new extra-spec/property along the lines of what Jay Pipes proposed.

Changed in nova:
assignee: Chris Friesen (cbf123) → Stephen Finucane (stephenfinucane)
Changed in nova:
assignee: Stephen Finucane (stephenfinucane) → Huachang (davidhqwang)
Changed in nova:
assignee: Huachang (davidhqwang) → Stephen Finucane (stephenfinucane)
Changed in nova:
assignee: Stephen Finucane (stephenfinucane) → Huachang (davidhqwang)
Changed in nova:
assignee: Huachang (davidhqwang) → Stephen Finucane (stephenfinucane)
tags: added: libvirt
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers