test_no_migrations_have_downgrade is broken

Bug #1680240 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Matt Riedemann

Bug Description

We have a unit test to check if a database migration script has a downgrade method, but it's broken since it didn't catch this:

https://review.openstack.org/#/c/453025/2/nova/db/sqlalchemy/migrate_repo/versions/359_add_service_uuid.py

Tags: db testing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/453872

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/453872
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f845e179687695d4b146c0143f4fa035d115fdd4
Submitter: Jenkins
Branch: master

commit f845e179687695d4b146c0143f4fa035d115fdd4
Author: Matt Riedemann <email address hidden>
Date: Wed Apr 5 17:00:05 2017 -0400

    Fix test_no_migrations_have_downgrade

    This wasn't walking the correct directory and it wasn't
    including the API database migrations.

    Change-Id: Idff0e8089faf4025a080a5842ff65eaad7b6fdb8
    Closes-Bug: #1680240

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b1

This issue was fixed in the openstack/nova 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.