Potential for NameError when logging volume encryptor

[Matt Riedemann]

This change introduced the possibility for a NameError if "control_location" is not in kwargs:

https://review.openstack.org/#/c/393901/12/nova/volume/encryptors/__init__.py@82

[Matt Riedemann (mriedem)]

I guess this is low priority since control_location is required for an encryption type in cinder:

https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_type_encryption.py#L62

https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_type_encryption.py#L70

So we wouldn't really hit this case anyway, but we are checking for it in the nova code.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/453265

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lee Yarwood (<email address hidden>) on branch: master
Review: https://review.openstack.org/453265
Reason: I37ffc90c0bd57029fced251b5cfd7cd4318a0292 is dropping this code from Nova.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

[Matt Riedemann (mriedem)]

The code was moved from nova to os-brick so marked as won't fix.