api-ref: os-extended-volumes:volumes_attached keys are not described

Bug #1675559 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
John Garbutt

Bug Description

In the api-ref for server details we have os-extended-volumes:volumes_attached which just says it's an array of attached volumes. At 2.1 it's a list of dicts with a single 'id' key which is the volume id. After 2.3 the list of dicts can also contain the 'delete_on_termination' key.

We don't describe the actual contents of that dict in the list, i.e. the id and delete_on_termination keys.

We need to add os-extended-volumes:volumes_attached.id and os-extended-volumes:volumes_attached.delete_on_termination keys to the server details reference and note that delete_on_termination is only shown with microversion >= 2.3.

Tags: api-ref
Matt Riedemann (mriedem)
Changed in nova:
assignee: nobody → Matt Riedemann (mriedem)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/449809

Changed in nova:
status: Confirmed → In Progress
Changed in nova:
assignee: Matt Riedemann (mriedem) → Ghanshyam Mann (ghanshyammann)
Changed in nova:
assignee: Ghanshyam Mann (ghanshyammann) → John Garbutt (johngarbutt)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/449809
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=28831f3b3d5b889a8e260b007b4010a0ed571ec0
Submitter: Jenkins
Branch: master

commit 28831f3b3d5b889a8e260b007b4010a0ed571ec0
Author: Matt Riedemann <email address hidden>
Date: Fri Mar 24 16:27:06 2017 -0400

    api-ref: fix os-extended-volumes:volumes_attached in servers responses

    There are two main changes here:

    1. The contents of the os-extended-volumes:volumes_attached list are
       described, which are the id and delete_on_termination keys, the latter
       being introduced in the GET /servers response in 2.3.

    2. The os-extended-volumes:volumes_attached parameters are removed from
       the PUT /servers and POST /servers responses, since we don't actually
       include those in the response for create and update operations, only
       GET /servers/{server_id} and GET /servers/detail operations.
       Note: create server is fixed in a follow up patch.

    Change-Id: Ic92055e3095d220a3a11e35628f04e9e67c6b71a
    Closes-Bug: #1675559

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b1

This issue was fixed in the openstack/nova 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.