OpenStack Compute (nova)

fdatasync() usage breaks Windows compatibility

Bug #1671435 reported by Lucian Petrut
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Lucian Petrut

Bug Description

The following change uses fdatasync when fetching Glance images, which is not supported on Windows: Id9905a87f16f66530623800e33e2581c555ae81d

For this reason, this operation is now failing on Windows.
Trace: http://paste.openstack.org/raw/602054/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/443583

Changed in nova:
assignee: nobody → Lucian Petrut (petrutlucian94)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/443583
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d9ed8a7235cc6529a1d26b86da43ff9278c690be
Submitter: Jenkins
Branch: master

commit d9ed8a7235cc6529a1d26b86da43ff9278c690be
Author: Lucian Petrut <email address hidden>
Date: Thu Mar 9 13:09:33 2017 +0200

    Avoid using fdatasync() when fetching images

    fdatasync is not available on Windows, for which reason this
    operation now fails.

    This change switches to fsync, which is platform independent.

    Closes-Bug: #1671435

    Change-Id: I71ac19160f198a97bb1834c5c81684758f129bcc

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b1

This issue was fixed in the openstack/nova 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.