Change the error message when injected file path length exceeds quota

[Archana Prabhakar]

I set the below quota value

{"quota_set":{"injected_file_path_bytes":1}}

I deployed a VM whose injected file path length was 2 bytes.

"personality": [
            {
                "path": "/etc/banners.txt",
                "contents": "ICAgICAgDQoiQSBjbG91ZCBkb2VzIG5vdCBrbm93IHdoeSBp dCBtb3ZlcyBpbiBqdXN0IHN1Y2ggYSBkaXJlY3Rpb24gYW5k IGF0IHN1Y2ggYSBzcGVlZC4uLkl0IGZlZWxzIGFuIGltcHVs c2lvbi4uLnRoaXMgaXMgdGhlIHBsYWNlIHRvIGdvIG5vdy4g QnV0IHRoZSBza3kga25vd3MgdGhlIHJlYXNvbnMgYW5kIHRo ZSBwYXR0ZXJucyBiZWhpbmQgYWxsIGNsb3VkcywgYW5kIHlv dSB3aWxsIGtub3csIHRvbywgd2hlbiB5b3UgbGlmdCB5b3Vy c2VsZiBoaWdoIGVub3VnaCB0byBzZWUgYmV5b25kIGhvcml6 b25zLiINCg0KLVJpY2hhcmQgQmFjaA=="
            }
        ],

The deploy failed with error as follows.

{
    "forbidden": {
        "message": "Personality file path too long",
        "code": 403
    }
}

problem1 :
=========

The error message must clearly display the exact quota name i.e injected_file_path_bytes and must also state that it is set to 1 like "Personality injected_file_path_bytes exceeds the maximum length [1]" or like "InjectedFilePathLengthExceedsLimit: Requested filepath size 2 is larger than maximum allowed limit 1"

problem2 :
=========

{
    "forbidden": {
        "message": "Personality file content too long",
        "code": 403
    }
}

[Divya K Konoor (dikonoor)]

This bug affects nova and not keystone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/453040

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/453040
Reason: This review is > 4 weeks without comment, and is not mergable in it's current state. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/453040
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=34242dbdbfdf3a24f77b10745672a78dcfc23858
Submitter: Jenkins
Branch: master

commit 34242dbdbfdf3a24f77b10745672a78dcfc23858
Author: Sihan Wang <email address hidden>
Date: Tue Apr 4 07:05:34 2017 +0000

    Show quota detail when inject file quota exceeds

    Provide quota info when:
    1) inject file path is too long
    2) inject file content is too long

    Change-Id: If5235c47b8d4372e7e1b88f456391c012c843605
    Closes-Bug: #1668163

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b1 development milestone.