instance.delete notification is missing for unscheduled instance

Bug #1665263 reported by Balazs Gibizer on 2017-02-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
High
Matt Riedemann
Ocata
High
Matt Riedemann

Bug Description

Description
===========
It seems that the Move instance creation to conductor commit [1] changed when and how the instance.delete notification is emitted for an unscheduled instance. Unfortunately the legacy notification doesn't have test coverage and the versioned notification coverage are still on review [2] for this case.

Before [1] the instance.delete for an unscheduled instance is emitted from here [3]. But after [1] the execution of the same delete operation goes to a new direction [4] and never reaches [3].
Before [1] the new test coverage in [2] was passing but now after [1] is merged the test_create_server_error fails as the instance.delete notification is not emitted.

[1] https://review.openstack.org/#/c/319379
[2] https://review.openstack.org/#/c/410297
[3] https://review.openstack.org/#/c/410297/9/nova/compute/api.py@1860
[4] https://review.openstack.org/#/c/319379/84/nova/compute/api.py@1790

Steps to reproduce
==================

Run the nova functional test in patch [2] before and after commit [1]. The test_create_server_error will pass before and fail after commit [1] due to missing instance.delete notification.

Environment
===========

Nova functional test env with based on commit f9d7b383a7cb12b6cd3e6117daf69b08620bf40f

Logs & Configs
==============

http://logs.openstack.org/97/410297/9/check/gate-nova-tox-functional-ubuntu-xenial/5875492/console.html#_2017-02-15_16_21_06_668774

Changed in nova:
assignee: nobody → Balazs Gibizer (balazs-gibizer)
tags: added: ocata-backport-potential
Matt Riedemann (mriedem) on 2017-02-16
Changed in nova:
status: New → Confirmed
importance: Undecided → High

Fix proposed to branch: master
Review: https://review.openstack.org/437222

Changed in nova:
status: Confirmed → In Progress
Changed in nova:
assignee: Balazs Gibizer (balazs-gibizer) → Dan Smith (danms)
Changed in nova:
assignee: Dan Smith (danms) → Matt Riedemann (mriedem)
Matt Riedemann (mriedem) on 2017-03-09
Changed in nova:
assignee: Matt Riedemann (mriedem) → Balazs Gibizer (balazs-gibizer)
Changed in nova:
assignee: Balazs Gibizer (balazs-gibizer) → Matt Riedemann (mriedem)

Reviewed: https://review.openstack.org/437222
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f9ac9531fb3259fe83642dce92d0d1901d0f067e
Submitter: Jenkins
Branch: master

commit f9ac9531fb3259fe83642dce92d0d1901d0f067e
Author: Balazs Gibizer <email address hidden>
Date: Thu Mar 9 17:28:02 2017 +0100

    Fix missing instance.delete notification

    The I8742071b55f018f864f5a382de20075a5b444a79 introduced cases when an
    instance object is destroyed without the instance.delete notification
    being emitted.

    This patch adds the necessary notification to restore legacy
    behaviour.

    Closes-Bug: #1665263
    Change-Id: I55ce90ca34c927c5dcd340fa5bdb0607a4ad4971

Changed in nova:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/441171
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0adc5bf0a4209657180df778ea6b95597fdc9ac0
Submitter: Jenkins
Branch: stable/ocata

commit 0adc5bf0a4209657180df778ea6b95597fdc9ac0
Author: Balazs Gibizer <email address hidden>
Date: Thu Mar 9 17:28:02 2017 +0100

    Fix missing instance.delete notification

    The I8742071b55f018f864f5a382de20075a5b444a79 introduced cases when an
    instance object is destroyed without the instance.delete notification
    being emitted.

    This patch adds the necessary notification to restore legacy
    behaviour.

    Closes-Bug: #1665263
    Change-Id: I55ce90ca34c927c5dcd340fa5bdb0607a4ad4971
    (cherry picked from commit f9ac9531fb3259fe83642dce92d0d1901d0f067e)

This issue was fixed in the openstack/nova 15.0.1 release.

This issue was fixed in the openstack/nova 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers