OpenStack Compute (nova)

Misuse of assertTrue in unit tests

Bug #1664446 reported by Takashi Natsume on 2017-02-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Takashi Natsume

Bug Description

There are some misuse of assertTrue in the following files.

* nova/tests/unit/scheduler/client/test_report.py
* nova/tests/unit/api/openstack/compute/test_hypervisors.py
* nova/tests/unit/objects/test_instance_device_metadata.py

https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/scheduler/client/test_report.py#L522
https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/api/openstack/compute/test_hypervisors.py#L316
https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/api/openstack/compute/test_hypervisors.py#L362
https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/objects/test_instance_device_metadata.py#L60
https://github.com/openstack/nova/blob/9a44d56f65b0e9334ec201f290e853c3e7af6981/nova/tests/unit/objects/test_instance_device_metadata.py#L64

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-14: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/433454

Changed in nova:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-15: Fix merged to nova (master)

Reviewed: https://review.openstack.org/433454
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5b49f4dfd288b02fd2b361dcc29f4a83f1468d3a
Submitter: Jenkins
Branch: master

commit 5b49f4dfd288b02fd2b361dcc29f4a83f1468d3a
Author: Takashi NATSUME <email address hidden>
Date: Tue Feb 14 14:23:46 2017 +0900

Fix misuse of assertTrue

Fix misuse of assertTrue in the following files.

    * nova/tests/unit/api/openstack/compute/test_hypervisors.py
    * nova/tests/unit/objects/test_instance_device_metadata.py
    * nova/tests/unit/scheduler/client/test_report.py

Change-Id: I5dd869ddec53cf0b9d27d99cb01d780e361a5810
Closes-Bug: #1664446

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-15: Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/434061

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-01: Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/434061
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8bb80d15787c0fefd35f8bb7a4730e017c154b0d
Submitter: Jenkins
Branch: stable/ocata

commit 8bb80d15787c0fefd35f8bb7a4730e017c154b0d
Author: Takashi NATSUME <email address hidden>
Date: Tue Feb 14 14:23:46 2017 +0900

Fix misuse of assertTrue

Fix misuse of assertTrue in the following files.

    * nova/tests/unit/api/openstack/compute/test_hypervisors.py
    * nova/tests/unit/objects/test_instance_device_metadata.py
    * nova/tests/unit/scheduler/client/test_report.py

    Change-Id: I5dd869ddec53cf0b9d27d99cb01d780e361a5810
    Closes-Bug: #1664446
    (cherry-picked from commit 5b49f4dfd288b02fd2b361dcc29f4a83f1468d3a)